[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

[GitBox <gi...@apache.org>]

XenoAmess edited a comment on pull request #118:
URL: https://github.com/apache/commons-io/pull/118#issuecomment-669143244


   @sebbASF
   
   > AFAICT the new classes UnsyncBufferedReader etc are not actually used (except in test code).
   
   yes, they are not quite used, but used for being parent class of 
   
   > I would expect all the contentEquals methods to remain exactly the same except for changes to the input sources.
   > The logic should remain unchanged (otherwise the new classes are not proper replacements).
   
   It can, but have huge performance lost.
   
   I also used another trick in those contentEquals functions, which cannot be used if we use that classes.
   And if we use the two classes there, will be 1 time slower than the functions we used in this pr (still be about 2 times faster than original)
   
   > Likewise I would not expect to see any changes to test cases, only new ones for the new classes, and perhaps a few new samples for existing methods where the coverage is incomplete.
   
   The changes in test are already moved to another pr, at https://github.com/apache/commons-io/pull/137
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org