You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/01/09 12:46:33 UTC
Review Request 55340: Hive View 2.0: Introduction of worksheets for
query editor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55340/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19424
https://issues.apache.org/jira/browse/AMBARI-19424
Repository: ambari
Description
-------
Created worksheet model.
Created queries and query route.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/multiple-database-search-bar.js 384368f
contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js f08e5a6
contrib/views/hive20/src/main/resources/ui/app/configs/top-level-tabs.js 6f04f0a
contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/router.js 46150f4
contrib/views/hive20/src/main/resources/ui/app/routes/queries.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/routes/query.js 9e22432
contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4d8fca4
contrib/views/hive20/src/main/resources/ui/app/templates/components/multiple-database-search-bar.hbs 57001ed
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 376afe7
contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs 69fc657
Diff: https://reviews.apache.org/r/55340/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 55340: Hive View 2.0: Introduction of worksheets
for query editor
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55340/#review161044
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Choudhary
On Jan. 9, 2017, 12:46 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55340/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 12:46 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19424
> https://issues.apache.org/jira/browse/AMBARI-19424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created worksheet model.
> Created queries and query route.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/multiple-database-search-bar.js 384368f
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js f08e5a6
> contrib/views/hive20/src/main/resources/ui/app/configs/top-level-tabs.js 6f04f0a
> contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/router.js 46150f4
> contrib/views/hive20/src/main/resources/ui/app/routes/queries.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/routes/query.js 9e22432
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4d8fca4
> contrib/views/hive20/src/main/resources/ui/app/templates/components/multiple-database-search-bar.hbs 57001ed
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 376afe7
> contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs 69fc657
>
> Diff: https://reviews.apache.org/r/55340/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 55340: Hive View 2.0: Introduction of worksheets
for query editor
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55340/#review161043
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Jan. 9, 2017, 12:46 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55340/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 12:46 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19424
> https://issues.apache.org/jira/browse/AMBARI-19424
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created worksheet model.
> Created queries and query route.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/multiple-database-search-bar.js 384368f
> contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js f08e5a6
> contrib/views/hive20/src/main/resources/ui/app/configs/top-level-tabs.js 6f04f0a
> contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/router.js 46150f4
> contrib/views/hive20/src/main/resources/ui/app/routes/queries.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/routes/query.js 9e22432
> contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4d8fca4
> contrib/views/hive20/src/main/resources/ui/app/templates/components/multiple-database-search-bar.hbs 57001ed
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 376afe7
> contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs 69fc657
>
> Diff: https://reviews.apache.org/r/55340/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>