[jira] [Commented] (HBASE-19787) Fix or disable tests broken in branch-2 so can cut beta-1

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324602#comment-16324602 ] 

stack commented on HBASE-19787:
-------------------------------

Here is changeset note:


    HBASE-19787 Fix or disable tests broken in branch-2 so can cut beta-1

    M dev-support/make_rc.sh
      Disable checkstyle building site. Its an issue being fixed over in HBASE-19780

    M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
      The clusterid was being set into the process only after the
      regionserver registers with the Master. That can be too late for some
      test clients in particular. e.g. TestZKAsyncRegistry needs it as soon
      as it goes to run which could be before Master had called its run
      method  which is regionserver run method which then calls back to the
      master to register itself... and only then do we set the clusterid.
      HBASE-19694 changed start order which made it so this test failed.
      Setting the clusterid right after we set it in zk makes the test pass.

      Another change was that backup masters were not going down on stop.
      Backup masters were sleeping for the default zk period which is 90
      seconds. They were not being woken up to check for stop. On stop
      master now tells active master manager.

    M hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXConnectorServer.java
      Prevent creation of acl table. Messes up our being able to go down
      promptly.

    M hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRegionsOnMasterOptions.java
    M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java
    M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReadRequestMetrics.java
      Disabled for now because it wants to run with regions on the Master...
      currently broke!

    M hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java
      Add a bit of debugging.

    M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSAsyncFSWAL.java
      Disabled. Fails 40% of the time.

    M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDLSFSHLog.java
      Disabled. Fails 33% of the time.

    Disabled stochastic load balancer for favored nodes because it fails on
    occasion and we are not doing favored nodes in branch-2.


Filing follow-on issues.

> Fix or disable tests broken in branch-2 so can cut beta-1
> ---------------------------------------------------------
>
>                 Key: HBASE-19787
>                 URL: https://issues.apache.org/jira/browse/HBASE-19787
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19787.branch-2.001.patch
>
>
> Appy's dashboard for 2.0 https://builds.apache.org/job/HBase-Find-Flaky-Tests-branch2.0/lastSuccessfulBuild/artifact/dashboard.html and a GCE run last night showed how bad of a state our unit tests are in on tip of branch-2. This issue does triage fixing and disabling so I can push out the beta-1. Its done as a subtask of HBASE-19694 because a few of the tests were broke by this commit.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)