You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/07/19 15:00:57 UTC

[GitHub] [accumulo] keith-turner opened a new issue #2208: Move TabletServer.checkTabletMetadata() to AssignmentHandler and improve messages

keith-turner opened a new issue #2208:
URL: https://github.com/apache/accumulo/issues/2208


   The static method [TabletServer.checkTabletMetadata()](https://github.com/apache/accumulo/blob/f5df4f9681736d35e14b92c58033a1cf062b3d4e/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java#L926) is only called by [AssignmentHandler](https://github.com/apache/accumulo/blob/f5df4f9681736d35e14b92c58033a1cf062b3d4e/server/tserver/src/main/java/org/apache/accumulo/tserver/AssignmentHandler.java#L106) when loading a tablet.   This method could be moved to the AssignmentHandler class.  All of the error messages in the methods could be improved to provide information that the problems were seen when trying to load a tablet.  For example could change the following :
   
   ```java
       if (!extent.equals(meta.getExtent())) {
         log.info("Tablet extent mismatch {} {}", extent, meta.getExtent());
         return false;
       }
   ```
   
   to the following
   
   ```java
       if (!extent.equals(meta.getExtent())) {
         log.info("Saw metadata issue when loading tablet : Tablet extent mismatch {} {}", extent, meta.getExtent());
         return false;
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] keith-turner commented on issue #2208: Move TabletServer.checkTabletMetadata() to AssignmentHandler and improve messages

Posted by GitBox <gi...@apache.org>.
keith-turner commented on issue #2208:
URL: https://github.com/apache/accumulo/issues/2208#issuecomment-954807135


   > Hi @keith-turner Can I work on this. seems like there is no PR for this
   
   Sure.  I reassigned the issue to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] tulikavijay commented on issue #2208: Move TabletServer.checkTabletMetadata() to AssignmentHandler and improve messages

Posted by GitBox <gi...@apache.org>.
tulikavijay commented on issue #2208:
URL: https://github.com/apache/accumulo/issues/2208#issuecomment-954800498


   Hi @keith-turner Can I work on this. seems like there is no PR for this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] SivaTharun commented on issue #2208: Move TabletServer.checkTabletMetadata() to AssignmentHandler and improve messages

Posted by GitBox <gi...@apache.org>.
SivaTharun commented on issue #2208:
URL: https://github.com/apache/accumulo/issues/2208#issuecomment-883354704


   @keith-turner can i work on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] DomGarguilo closed issue #2208: Move TabletServer.checkTabletMetadata() to AssignmentHandler and improve messages

Posted by GitBox <gi...@apache.org>.
DomGarguilo closed issue #2208:
URL: https://github.com/apache/accumulo/issues/2208


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org