You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2012/06/26 18:32:05 UTC
[Bug 6811] New: Add option to sa-learn (and ArchiveIterator) to
override a built-in message size limit
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6811
Priority: P2
Bug ID: 6811
Assignee: dev@spamassassin.apache.org
Summary: Add option to sa-learn (and ArchiveIterator) to
override a built-in message size limit
Severity: enhancement
Classification: Unclassified
OS: All
Reporter: Mark.Martinec@ijs.si
Hardware: All
Status: NEW
Version: SVN Trunk (Latest Devel Version)
Component: Learner
Product: Spamassassin
When feeding some freshly hand-collected spam folder to sa-learn
I'm sometimes dismayed that messages larger than 256 KiB are ignored
unconditionally, even though they could sometimes offer a good
contribution to a set of tokens in Bayes.
It would be nice to be able to override a built-in size limit
of 256 KiB in ArchiveIterator, or just to disable it form a
command line option to sa-learn.
There was a somewhat related ticket:
Bug 4976 - increase default msg size limit from 250KB
which resulted in bumping up the size limit in spamc, but
ignored an equivalent limit in ArchiveIterator.
Attached is a proposed patch. It adds:
- a command line option --max-size to sa-learn (same option name as in spamc),
- option 'opt_max_size' to ArchiveIterator's contructor (and implements it),
- preserves option 'opt_all' for compatibility, but implements it
through 'opt_max_size' to simplify conditionals in loops,
- enhance some size-related debug log entries in ArchiveIterator,
- drops line-based limit approximation in some code paths of
ArchiveIterator by an exact byte-size limit as in other code sections.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6811] Add option to sa-learn (and ArchiveIterator) to override
a built-in message size limit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6811
--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
oops, lost one line:
Sending lib/Mail/SpamAssassin/ArchiveIterator.pm
Committed revision 1354108.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6811] Add option to sa-learn (and ArchiveIterator) to override
a built-in message size limit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6811
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Mark Martinec <Ma...@ijs.si> ---
So this seems to have been fixed, closing.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6811] Add option to sa-learn (and ArchiveIterator) to override
a built-in message size limit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6811
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.4.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6811] Add option to sa-learn (and ArchiveIterator) to override
a built-in message size limit
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6811
--- Comment #1 from Mark Martinec <Ma...@ijs.si> ---
Created attachment 5077
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5077&action=edit
proposed patch
trunk (3.4):
Bug 6811: Add option to sa-learn (and ArchiveIterator)
to override a built-in message size limit
Sending lib/Mail/SpamAssassin/ArchiveIterator.pm
Sending sa-learn.raw
Sending spamassassin.raw
Committed revision 1354103.
--
You are receiving this mail because:
You are the assignee for the bug.