You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2012/09/11 23:20:08 UTC
[jira] [Created] (QPID-4297) Broker should not rely on
Subject.getPrincipals.iterator().next() to find 'username principal'
Keith Wall created QPID-4297:
--------------------------------
Summary: Broker should not rely on Subject.getPrincipals.iterator().next() to find 'username principal'
Key: QPID-4297
URL: https://issues.apache.org/jira/browse/QPID-4297
Project: Qpid
Issue Type: Improvement
Components: Java Broker
Reporter: Keith Wall
Fix For: 0.19
The Broker uses the idiom Subject.getPrincipals.iterator().next() in a couple of places to find the principal corresponding to the username of the logged on user. This assumes that corresponding principal will always be returned first. This may not be a safe assumption across different JVM providers, different JVM versions or when running Qpid with a container.
This should be replaced by our utility methods AuthenticatedPrincipal#getOptionalAuthenticatedPrincipalFromSubject and
AuthenticatedPrincipal#getAuthenticatedPrincipalFromSubject
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4297) Broker should not rely on
Subject.getPrincipals.iterator().next() to find 'username principal'
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-4297.
----------------------------------
Resolution: Fixed
Looks good to me.
> Broker should not rely on Subject.getPrincipals.iterator().next() to find 'username principal'
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-4297
> URL: https://issues.apache.org/jira/browse/QPID-4297
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.19
>
>
> The Broker uses the idiom Subject.getPrincipals.iterator().next() in a couple of places to find the principal corresponding to the username of the logged on user. This assumes that corresponding principal will always be returned first. This may not be a safe assumption across different JVM providers, different JVM versions or when running Qpid with a container.
> This should be replaced by our utility methods AuthenticatedPrincipal#getOptionalAuthenticatedPrincipalFromSubject and
> AuthenticatedPrincipal#getAuthenticatedPrincipalFromSubject
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4297) Broker should not rely on
Subject.getPrincipals.iterator().next() to find 'username principal'
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-4297:
-----------------------------
Status: Ready To Review (was: In Progress)
> Broker should not rely on Subject.getPrincipals.iterator().next() to find 'username principal'
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-4297
> URL: https://issues.apache.org/jira/browse/QPID-4297
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
>
> The Broker uses the idiom Subject.getPrincipals.iterator().next() in a couple of places to find the principal corresponding to the username of the logged on user. This assumes that corresponding principal will always be returned first. This may not be a safe assumption across different JVM providers, different JVM versions or when running Qpid with a container.
> This should be replaced by our utility methods AuthenticatedPrincipal#getOptionalAuthenticatedPrincipalFromSubject and
> AuthenticatedPrincipal#getAuthenticatedPrincipalFromSubject
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4297) Broker should not rely on
Subject.getPrincipals.iterator().next() to find 'username principal'
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4297:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
Patch applied, Robbie could you review please?
> Broker should not rely on Subject.getPrincipals.iterator().next() to find 'username principal'
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-4297
> URL: https://issues.apache.org/jira/browse/QPID-4297
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Robbie Gemmell
> Fix For: 0.19
>
>
> The Broker uses the idiom Subject.getPrincipals.iterator().next() in a couple of places to find the principal corresponding to the username of the logged on user. This assumes that corresponding principal will always be returned first. This may not be a safe assumption across different JVM providers, different JVM versions or when running Qpid with a container.
> This should be replaced by our utility methods AuthenticatedPrincipal#getOptionalAuthenticatedPrincipalFromSubject and
> AuthenticatedPrincipal#getAuthenticatedPrincipalFromSubject
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Assigned] (QPID-4297) Broker should not rely on
Subject.getPrincipals.iterator().next() to find 'username principal'
Posted by "Keith Wall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-4297:
--------------------------------
Assignee: Keith Wall
> Broker should not rely on Subject.getPrincipals.iterator().next() to find 'username principal'
> ----------------------------------------------------------------------------------------------
>
> Key: QPID-4297
> URL: https://issues.apache.org/jira/browse/QPID-4297
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Fix For: 0.19
>
>
> The Broker uses the idiom Subject.getPrincipals.iterator().next() in a couple of places to find the principal corresponding to the username of the logged on user. This assumes that corresponding principal will always be returned first. This may not be a safe assumption across different JVM providers, different JVM versions or when running Qpid with a container.
> This should be replaced by our utility methods AuthenticatedPrincipal#getOptionalAuthenticatedPrincipalFromSubject and
> AuthenticatedPrincipal#getAuthenticatedPrincipalFromSubject
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org