[jira] [Commented] (FLINK-7853) Reject table function outer joins with predicates in Table API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206981#comment-16206981 ] 

ASF GitHub Bot commented on FLINK-7853:
---------------------------------------

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/4842

    [FLINK-7853] [table] Reject table function outer joins with predicates in table API

    # What is the purpose of the change
    
    Due to CALCITE-2004, this PR aims to temporarily restrict the predicates for table function outer join to be empty or literal true.
    
    ## Brief change log
    
      - Allow boolean literals in join conditions.
      - Restrict the table function left outer join predicates to be empty or literal true in `operators.scala`.
      - Add related tests.
      - Refine the documents.
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `CorrelateTest` and `CorrelateITCase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (docs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7853

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4842
    
----
commit 8fa458ffa94062f3e724908b67d75469cebf74b0
Author: Xingcan Cui <xi...@gmail.com>
Date:   2017-10-16T08:49:14Z

    [FLINK-7853] [table] Reject table function outer joins with predicates in Table API

----


> Reject table function outer joins with predicates in Table API
> --------------------------------------------------------------
>
>                 Key: FLINK-7853
>                 URL: https://issues.apache.org/jira/browse/FLINK-7853
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Xingcan Cui
>            Assignee: Xingcan Cui
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> Due to CALCITE-2004, the table function outer joins can not be normally executed. We should cover it up by rejecting join predicates temporarily, until the issue is fixed in Calcite.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)