You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/03 08:18:51 UTC
[GitHub] [cloudstack] weizhouapache opened a new issue #3859:
test_privategw_acl.py failed in some Trillian tests
weizhouapache opened a new issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859
##### ISSUE TYPE
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
VPC private gateway
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
4.14
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
Advanced zone
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
~~~
Smoke test test_privategw_acl.py failed in some Trillian tests.
~~~
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
see more details in https://github.com/apache/cloudstack/blob/master/test/integration/smoke/test_privategw_acl.py#L317-L381
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
No errors/failures
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
Some tests failed. For example
https://github.com/apache/cloudstack/pull/3477#issuecomment-571288662
https://github.com/apache/cloudstack/pull/3836#issuecomment-579981259
https://github.com/apache/cloudstack/pull/3851#issuecomment-580891071
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-585786614
Okay @weizhouapache do we need to fix that in the test data config, test or in CloudStack java code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-585566269
Failure seen in latest master smoketests - https://github.com/apache/cloudstack/pull/3850#issuecomment-585511968
@weizhouapache I see this issue, are you working on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587355882
> I think it is expected that vlan shouldn't be same?
@rhtyd exactly. however in smoke test it creates two VPCs and private gateway with same vlan for each VPC, then test the connectivity between them. hence we have to add a new parameter bypassvlanoverlapcheck to private gateway so that the test can still go on.
> @weizhouapache - should we fix this in the test or test's config instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-588786500
Great, thanks @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587271489
@weizhouapache are you send a fix? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-588758592
I can take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-584658892
https://github.com/apache/cloudstack/pull/3601#issuecomment-584493660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-585608028
@rhtyd yes
found the root cause: https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L4472
private gateway in two VPCs use the same isolated network, if they have same vlan and cidr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587324188
@rhtyd we need to fix it in java code. it is not simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-588622221
@andrijapanicsb @DaanHoogland ^^ let's triage/assign this, could @Spaceman1984 pick this up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-588768530
ok, Thanks @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587355882
> I think it is expected that vlan shouldn't be same?
@rhtyd exactly. however in smoke test it creates two VPCs and private gateway with same vlan for each VPC, then test the connectivity between them. hence we have to add a new parameter bypassvlanoverlapcheck to private gateway so that the test can still go on.
> @weizhouapache - should we fix this in the test or test's config instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-588762757
@rhtyd @Spaceman1984 I will create a PR today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3859: test_privategw_acl.py
failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-587341421
I think it is expected that vlan shouldn't be same? @weizhouapache - should we fix this in the test or test's config instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3859:
test_privategw_acl.py failed in some Trillian tests
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3859: test_privategw_acl.py failed in some Trillian tests
URL: https://github.com/apache/cloudstack/issues/3859#issuecomment-583612278
https://github.com/apache/cloudstack/pull/3871#issuecomment-583599818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services