You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/15 14:57:04 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #11759:
FLINK-17142: Bump ORC dependency version to 1.5.6
JingsongLi commented on a change in pull request #11759: FLINK-17142: Bump ORC dependency version to 1.5.6
URL: https://github.com/apache/flink/pull/11759#discussion_r408908624
##########
File path: flink-formats/flink-orc-nohive/src/main/java/org/apache/flink/orc/nohive/vector/AbstractOrcNoHiveVector.java
##########
@@ -138,9 +138,11 @@ private static BytesColumnVector createBytesVector(int batchSize, Object value)
bcv.isNull[0] = true;
bcv.isRepeating = true;
} else {
- bcv.fill(value instanceof byte[] ?
- (byte[]) value :
- value.toString().getBytes(StandardCharsets.UTF_8));
+ byte[] bytes = value instanceof byte[] ?
Review comment:
Yes, good job, it should same to `AbstractOrcColumnVector`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services