You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 23:43:47 UTC

[GitHub] [arrow] kou commented on a change in pull request #11562: ARROW-14446: [Docs][Release] Update documentation on verification of release candidates

kou commented on a change in pull request #11562:
URL: https://github.com/apache/arrow/pull/11562#discussion_r765327347



##########
File path: dev/tasks/verify-rc/github.Almalinux.amd64.yml
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+jobs:
+  verify:
+    name: "Verify release candidate AlmaLinux"
+    runs:
+      using: 'docker'
+      image: 'AlmaLinuxDockerfile'
+

Review comment:
       You want to work on Crossbow task in this pull request, right?
   
   We should add `almalinux-verify-rc-*` and `ubuntu-verify-rc-*` entries to `docker-compose.yml` and use it in `dev/tasks/`. I think that it will be something like the following:
   
   ```yaml
   almalinux-verify-rc-source:
     image: almalinux:${ALMALINUX}
     volumes:
       - .:/arrow:delegated
     command: >
       /bin/bash -c "
         /arrow/ci/dev/release/setup-rhel-rebuilds.sh &&
         /arrow/ci/dev/release/verify-release-candidate.sh source ${VERSION} ${RC}"
   ```
   
   Note that we also need to add `ALMALINUX=8` to `.env`.
   
   We can use this by `archery docker run -e VERSION=6.0.1 -e RC=1 almalinux-verify-rc-source`.

##########
File path: dev/release/VERIFY.md
##########
@@ -74,3 +74,27 @@ You need to set `PKG_CONFIG_PATH` to find libffi on macOS:
 ```console
 % export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig:$PKG_CONFIG_PATH
 ```
+
+### C++, C#, C GLib, Go, Java, JavaScript, Python, Ruby
+
+Example scripts to install the dependencies to run the verification 
+script for verifying the source on Ubuntu 20.04, Rocky Linux 8 and 
+AlmaLinux 8 are in this folder and named `setup-ubuntu.sh` and 
+`setup-rhel-rebuild.sh`. These can be adapted to different 

Review comment:
       ```suggestion
   `setup-rhel-rebuilds.sh`. These can be adapted to different 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org