You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Donal Lafferty <do...@citrix.com> on 2013/01/28 22:56:15 UTC
Re: Review Request: Hyper-V 2012 Plugin Phase 1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9126/
-----------------------------------------------------------
(Updated Jan. 28, 2013, 9:56 p.m.)
Review request for cloudstack, Chip Childers and Alex Huang.
Description
-------
First cut of HyperV plugin, cloud-api changes to support VHDX image type, and test changes to deal with Windows clock accuracy and URI semantics.
Large size due to inclusion of a disk image used for some of the unit testing. Not all unit test dependencies in place. I'd rather download image files from a source than add them to the repo, but haven't found a link for this yet.
This addresses bug CLOUDSTACK-999.
Diffs
-----
Diff: https://reviews.apache.org/r/9126/diff/
Testing
-------
Thanks,
Donal Lafferty
RE: Review Request: Hyper-V 2012 Plugin Phase 1
Posted by Donal Lafferty <do...@citrix.com>.
Hmm. I must have created the patch incorrectly.
I'll have to do a bit more reading on patch creation and resubmit. (tomorrow :( )
DL
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: 28 January 2013 22:19
> To: Donal Lafferty
> Cc: cloudstack; Alex Huang
> Subject: Re: Review Request: Hyper-V 2012 Plugin Phase 1
>
> It should have been the base diff, not an attachment. Otherwise we can't
> use reviewboard to actually review the changes.
>
> On Mon, Jan 28, 2013 at 5:12 PM, Donal Lafferty <do...@citrix.com>
> wrote:
> > The patch was add as a file attachment.
> >
> > Is that the correct procedure?
> >
> > DL
> >
> >> -----Original Message-----
> >> From: Donal Lafferty [mailto:noreply@reviews.apache.org] On Behalf Of
> >> Donal Lafferty
> >> Sent: 28 January 2013 21:56
> >> To: Chip Childers; Alex Huang
> >> Cc: cloudstack; Donal Lafferty
> >> Subject: Re: Review Request: Hyper-V 2012 Plugin Phase 1
> >>
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9126/
> >> -----------------------------------------------------------
> >>
> >> (Updated Jan. 28, 2013, 9:56 p.m.)
> >>
> >>
> >> Review request for cloudstack, Chip Childers and Alex Huang.
> >>
> >>
> >> Description
> >> -------
> >>
> >> First cut of HyperV plugin, cloud-api changes to support VHDX image
> >> type, and test changes to deal with Windows clock accuracy and URI
> semantics.
> >> Large size due to inclusion of a disk image used for some of the unit
> testing.
> >> Not all unit test dependencies in place. I'd rather download image
> >> files from a source than add them to the repo, but haven't found a link for
> this yet.
> >>
> >>
> >> This addresses bug CLOUDSTACK-999.
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>
> >> Diff: https://reviews.apache.org/r/9126/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >>
> >> Thanks,
> >>
> >> Donal Lafferty
> >
Re: Review Request: Hyper-V 2012 Plugin Phase 1
Posted by Chip Childers <ch...@sungard.com>.
It should have been the base diff, not an attachment. Otherwise we
can't use reviewboard to actually review the changes.
On Mon, Jan 28, 2013 at 5:12 PM, Donal Lafferty
<do...@citrix.com> wrote:
> The patch was add as a file attachment.
>
> Is that the correct procedure?
>
> DL
>
>> -----Original Message-----
>> From: Donal Lafferty [mailto:noreply@reviews.apache.org] On Behalf Of
>> Donal Lafferty
>> Sent: 28 January 2013 21:56
>> To: Chip Childers; Alex Huang
>> Cc: cloudstack; Donal Lafferty
>> Subject: Re: Review Request: Hyper-V 2012 Plugin Phase 1
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9126/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 28, 2013, 9:56 p.m.)
>>
>>
>> Review request for cloudstack, Chip Childers and Alex Huang.
>>
>>
>> Description
>> -------
>>
>> First cut of HyperV plugin, cloud-api changes to support VHDX image type,
>> and test changes to deal with Windows clock accuracy and URI semantics.
>> Large size due to inclusion of a disk image used for some of the unit testing.
>> Not all unit test dependencies in place. I'd rather download image files from
>> a source than add them to the repo, but haven't found a link for this yet.
>>
>>
>> This addresses bug CLOUDSTACK-999.
>>
>>
>> Diffs
>> -----
>>
>>
>> Diff: https://reviews.apache.org/r/9126/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Donal Lafferty
>
RE: Review Request: Hyper-V 2012 Plugin Phase 1
Posted by Donal Lafferty <do...@citrix.com>.
The patch was add as a file attachment.
Is that the correct procedure?
DL
> -----Original Message-----
> From: Donal Lafferty [mailto:noreply@reviews.apache.org] On Behalf Of
> Donal Lafferty
> Sent: 28 January 2013 21:56
> To: Chip Childers; Alex Huang
> Cc: cloudstack; Donal Lafferty
> Subject: Re: Review Request: Hyper-V 2012 Plugin Phase 1
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9126/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 9:56 p.m.)
>
>
> Review request for cloudstack, Chip Childers and Alex Huang.
>
>
> Description
> -------
>
> First cut of HyperV plugin, cloud-api changes to support VHDX image type,
> and test changes to deal with Windows clock accuracy and URI semantics.
> Large size due to inclusion of a disk image used for some of the unit testing.
> Not all unit test dependencies in place. I'd rather download image files from
> a source than add them to the repo, but haven't found a link for this yet.
>
>
> This addresses bug CLOUDSTACK-999.
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/9126/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Donal Lafferty