You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/12/23 00:48:43 UTC

Review Request 29331: Re-enable docker recover test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
-------

Re-enable docker recover test.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp bed2d1005647d62b3ec013315b883d33990b896e 

Diff: https://reviews.apache.org/r/29331/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 29331: Re-enable docker recover test.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/#review69543
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Jan. 16, 2015, 5:27 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29331/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 5:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Re-enable docker recover test.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp 2105ae2 
> 
> Diff: https://reviews.apache.org/r/29331/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 29331: Re-enable docker recover test.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/
-----------------------------------------------------------

(Updated April 7, 2015, 12:36 a.m.)


Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Changes
-------

rebased


Repository: mesos


Description
-------

Re-enable docker recover test.


Diffs (updated)
-----

  src/tests/docker_containerizer_tests.cpp c772d4c836de18b0e87636cb42200356d24ec73d 

Diff: https://reviews.apache.org/r/29331/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 29331: Re-enable docker recover test.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/
-----------------------------------------------------------

(Updated Jan. 17, 2015, 1:27 a.m.)


Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Changes
-------

rebased


Repository: mesos-git


Description
-------

Re-enable docker recover test.


Diffs (updated)
-----

  src/tests/docker_containerizer_tests.cpp 2105ae2 

Diff: https://reviews.apache.org/r/29331/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 29331: Re-enable docker recover test.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 1:22 a.m.)


Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Repository: mesos-git


Description
-------

Re-enable docker recover test.


Diffs (updated)
-----

  src/tests/docker_containerizer_tests.cpp 2105ae2 

Diff: https://reviews.apache.org/r/29331/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 29331: Re-enable docker recover test.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/#review67190
-----------------------------------------------------------

Ship it!



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29331/#comment111061>

    This indentation takes too long to read. Suggestion:
    
    EXPECT_CALL(*mockDocker, stop(_, _, _))
      .WillOnce(FutureResult(
          &stop,
          Invoke((MockDocker*) docker.get(), &MockDocker::_stop)));


- Bernd Mathiske


On Jan. 6, 2015, 2:17 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29331/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 2:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Re-enable docker recover test.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp bed2d1005647d62b3ec013315b883d33990b896e 
> 
> Diff: https://reviews.apache.org/r/29331/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 29331: Re-enable docker recover test.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29331/
-----------------------------------------------------------

(Updated Jan. 6, 2015, 10:17 p.m.)


Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Repository: mesos-git


Description
-------

Re-enable docker recover test.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp bed2d1005647d62b3ec013315b883d33990b896e 

Diff: https://reviews.apache.org/r/29331/diff/


Testing
-------

make check


Thanks,

Timothy Chen