[GitHub] [iotdb] Beyyes commented on a diff in pull request #7060: [IOTDB-4174] Show RegionNum when show storagegroup

[GitBox <gi...@apache.org>]

Beyyes commented on code in PR #7060:
URL: https://github.com/apache/iotdb/pull/7060#discussion_r950654037


##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceHandler.java:
##########
@@ -47,8 +44,6 @@ public ServerContext createContext(TProtocol arg0, TProtocol arg1) {
 
   @Override
   public void deleteContext(ServerContext arg0, TProtocol arg1, TProtocol arg2) {
-    // release query resources.
-    processor.handleClientExit();

Review Comment:
   what's the usage of `processor.handleClientExit();` before?



##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -157,7 +157,7 @@ public TSStatus deleteStorageGroup(DeleteStorageGroupPlan plan) {
       LOGGER.warn("Storage group not exist", e);
       result
           .setCode(TSStatusCode.SUCCESS_STATUS.getStatusCode())
-          .setMessage("Storage group not exist");
+          .setMessage("Storage group not exist" + e.getMessage());

Review Comment:
   ```suggestion
             .setMessage("Storage group not exist: " + e.getMessage());
   ```



##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -176,7 +176,7 @@ public CountStorageGroupResp countMatchedStorageGroups(CountStorageGroupPlan pla
       LOGGER.error("Error StorageGroup name", e);
       result.setStatus(
           new TSStatus(TSStatusCode.STORAGE_GROUP_NOT_EXIST.getStatusCode())
-              .setMessage("Error StorageGroup name"));
+              .setMessage("Error StorageGroup name" + e.getMessage()));

Review Comment:
   ```suggestion
                 .setMessage("Error StorageGroup name: " + e.getMessage()));
   ```



##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/IManager.java:
##########
@@ -306,6 +307,9 @@ Object getOrCreateDataPartition(
   /** Show ConfigNodes */
   TShowConfigNodesResp showConfigNodes();
 
+  /** Show StorageGroup */
+  TShowStorageGroupResp showStorageGroup(GetStorageGroupPlan getStorageGroupPlan);

Review Comment:
   add parameter `getStorageGroupPlan` for java doc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org