You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/15 23:04:05 UTC

[GitHub] [tvm] kparzysz-quic commented on pull request #12443: Use std::optional instead of dmlc::optional, NFC

kparzysz-quic commented on PR #12443:
URL: https://github.com/apache/tvm/pull/12443#issuecomment-1215962739

   > LGTM. BTW, do you prefer using `tvm::runtime::Optinonal` instead for TVM objects?
   
   I think that `tvm::runtime::Optional` is a part of the packed func interface, so I'm not sure if we can get rid of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org