You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/01 09:10:27 UTC

[GitHub] [inlong] gong commented on a diff in pull request #4882: [INLONG-4814][Sort][Manager] Declare the primary key for sink table when the query contains update/delete

gong commented on code in PR #4882:
URL: https://github.com/apache/inlong/pull/4882#discussion_r934307281


##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/table/JdbcDialects.java:
##########
@@ -44,6 +45,7 @@ public final class JdbcDialects {
         DIALECTS.add(new TDSQLPostgresDialect());
         DIALECTS.add(new SqlServerDialect());
         DIALECTS.add(new OracleDialect());
+        DIALECTS.add(new ClickHouseDialect());

Review Comment:
   It is redundancy. Because clickhouse load node use `dialect-impl` to register dialect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org