You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/19 19:56:34 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4696: sim/rptun: Trigger the callback only the sequnece number change

gustavonihei commented on a change in pull request #4696:
URL: https://github.com/apache/incubator-nuttx/pull/4696#discussion_r732197505



##########
File path: arch/sim/src/sim/up_rptun.c
##########
@@ -224,16 +224,20 @@ void up_rptun_loop(void)
     {
       if (dev->shmem != NULL)
         {
+          bool diff = false;

Review comment:
       ```suggestion
             bool should_notify = false;
   ```
   nit: suggestion for making the intent easier to comprehend.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org