You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@rya.apache.org by ejwhite922 <gi...@git.apache.org> on 2018/01/25 20:17:41 UTC

[GitHub] incubator-rya pull request #269: RYA-459 Fixed handling of comma-separated p...

GitHub user ejwhite922 opened a pull request:

    https://github.com/apache/incubator-rya/pull/269

    RYA-459 Fixed handling of comma-separated property file values in AccumuloIndexingConfiguration and MongoIndexingConfiguration

    ## Description
    AccumuloIndexingConfiguration and MongoIndexingConfiguration were not parsing comma-separated values properly (such as for metadata.properties) when reading from a properties file.  These were also not null safe like the other tags nor did they provide a default value.
    
    ### Tests
    Unit Tests
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-459)
    
    ### Checklist
    - [ ] Code Review
    - [ ] Squash Commits
    
    #### People To Review
    @isper3at 
    @kchilton2 
    @meiercaleb 
    @DLotts
    @pujav65 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ejwhite922/incubator-rya RYA-459_MetadataPropertiesConfiguration

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #269
    
----
commit c91b33514c4332817d50e472218175a97b088086
Author: eric.white <er...@...>
Date:   2018-01-25T20:12:40Z

    RYA-459 Fixed handling of comma-separated property file values in AccumuloIndexingConfiguration and MongoIndexingConfiguration

----


---

[GitHub] incubator-rya pull request #269: RYA-459 Fixed handling of comma-separated p...

Posted by jdasch <gi...@git.apache.org>.

Github user jdasch commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/269#discussion_r165655934
  
    --- Diff: extras/indexing/src/main/java/org/apache/rya/indexing/accumulo/AccumuloIndexingConfiguration.java ---
    @@ -287,15 +286,19 @@ public void setAccumuloTemporalPredicates(String[] predicates) {
         public String[] getAccumuloTemporalPredicates() {
             return getStrings(ConfigUtils.TEMPORAL_PREDICATES_LIST);
         }
    -    
    -    private static Set<RyaURI> getPropURIFromStrings(String ... props) {
    -        Set<RyaURI> properties = new HashSet<>();
    -        for(String prop: props) {
    -            properties.add(new RyaURI(prop));
    +
    +    private static Set<RyaURI> getPropURIFromStrings(final String... props) {
    +        final Set<RyaURI> properties = new HashSet<>();
    +        if (props != null) {
    +            for(final String prop : props) {
    +                if (prop != null) {
    --- End diff --
    
    Do we want/need an empty string check here?  Do we need/have a unit test to exercise this?


---