You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/05/13 12:44:12 UTC
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2109: Add Sqoop Engine
casionone commented on code in PR #2109:
URL: https://github.com/apache/incubator-linkis/pull/2109#discussion_r872358820
##########
LICENSE-binary:
##########
@@ -576,6 +576,7 @@ See licenses-binary/ for text of these licenses.
(Apache License, version 2.0) Apache ZooKeeper - Server (org.apache.zookeeper:zookeeper:3.4.6 - https://zookeeper.apache.org/)
(Apache License, version 2.0) Apache twill (org.apache.twill:* - https://twill.apache.org/)
(Apache License, version 2.0) Apache tephra (co.cask.tephra:* - https://tephra.apache.org/)
+ (Apache License, version 2.0) Apache Sqoop - Server (org.apache.sqoop:sqoop:1.4.6 - https://github.com/apache/sqoop/)
Review Comment:
LICENSE-sqoop.txt should be added to licenses-binary/LICENSE-sqoop.txt
just as https://github.com/apache/incubator-linkis/pull/2035/files#diff-38e53776e6465b9057e805920c3ec9de556ff1a4595b8c86724845411f91d312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org