You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/04 02:18:10 UTC
[GitHub] [superset] corbinrobb opened a new pull request #14978: [WIP] refactor: Convert TableElement to TypeScript
corbinrobb opened a new pull request #14978:
URL: https://github.com/apache/superset/pull/14978
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Converted TableElement to TypeScript.
Required me to move the expand icon with tooltip off the Collapse.Panel component on to the Collapse parent component where it was supposed to be. Allowed me to remove most of the inline styling in the expand icon because the styles are now being inherited correctly.
Made code more concise and readable wherever I could.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Should look and behave the same
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- To test TableElement navigate to the route superset/sqllab
- On the left towards the bottom there should be a drop-down saying Select table or type table name
- Use the drop-down and select some tables and below the drop-down, some TableElement components should appear
- Check them out
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] corbinrobb commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
corbinrobb commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861798062
@eschutho Hmm, mine is working as expected. The button originally doesn't sort the columns and just displays the way the table is sent and the button toggles between alphabetical and the original. In the picture it looks like that specific table is in alphabetical order already? That is kinda weird though because I also didn't change the logic in the sort function I just shortened it using ternary operators. Does it work on any of the tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
hughhhh commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854937982
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] corbinrobb commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
corbinrobb commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r651334277
##########
File path: superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -134,6 +136,19 @@ export default class SqlEditorLeftBar extends React.PureComponent {
this.props.actions.addTable(this.props.queryEditor, tableName, schemaName);
}
+ renderExpandIconWithTooltip = ({ isActive }) => (
+ <IconTooltip
+ style={{ transform: 'rotate(90deg)' }}
Review comment:
Certainly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861790422
@corbinrobb this looks great. I wasn't able to sort the columns in the test environment. Can you check and see if that is working for you? It should sort both ascending and descending.
<img width="425" alt="Superset" src="https://user-images.githubusercontent.com/5186919/122115306-2e1a3980-cdd9-11eb-8e2f-ef161e6d6cbb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (80ca81a) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
- Coverage 77.61% 77.45% -0.17%
==========================================
Files 965 969 +4
Lines 49503 49944 +441
Branches 6259 6423 +164
==========================================
+ Hits 38422 38682 +260
- Misses 10881 11057 +176
- Partials 200 205 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.23% <100.00%> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.00% <100.00%> (ø)` | |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-50.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `50.84% <0.00%> (-30.01%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `56.25% <0.00%> (-30.00%)` | :arrow_down: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `47.00% <0.00%> (-30.00%)` | :arrow_down: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `60.00% <0.00%> (-24.62%)` | :arrow_down: |
| [...components/DashboardBuilder/DashboardContainer.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQ29udGFpbmVyLnRzeA==) | `82.97% <0.00%> (-17.03%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `58.47% <0.00%> (-15.26%)` | :arrow_down: |
| ... and [87 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...80ca81a](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36401d3) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **increase** coverage by `0.07%`.
> The diff coverage is `92.72%`.
> :exclamation: Current head 36401d3 differs from pull request most recent head e3191a9. Consider uploading reports for the commit e3191a9 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
+ Coverage 77.61% 77.68% +0.07%
==========================================
Files 965 965
Lines 49503 49541 +38
Branches 6259 6269 +10
==========================================
+ Hits 38422 38488 +66
+ Misses 10881 10850 -31
- Partials 200 203 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.64% <92.72%> (+0.16%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../components/Header/HeaderActionsDropdown/index.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9IZWFkZXJBY3Rpb25zRHJvcGRvd24vaW5kZXguanN4) | `68.42% <ø> (ø)` | |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `40.00% <ø> (ø)` | |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.60% <ø> (ø)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `88.67% <87.09%> (+88.67%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.20% <100.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `82.69% <100.00%> (+1.84%)` | :arrow_up: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `81.72% <100.00%> (+0.19%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...e3191a9](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r647755049
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -17,31 +17,49 @@
* under the License.
*/
import React, { useState } from 'react';
-import PropTypes from 'prop-types';
import Collapse from 'src/components/Collapse';
import Card from 'src/components/Card';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, styled } from '@superset-ui/core';
import { debounce } from 'lodash';
import { Tooltip } from 'src/components/Tooltip';
-import Icons from 'src/components/Icons';
import CopyToClipboard from '../../components/CopyToClipboard';
import { IconTooltip } from '../../components/IconTooltip';
-import ColumnElement from './ColumnElement';
+import ColumnElement, { ColumnKeyTypeType } from './ColumnElement';
import ShowSQL from './ShowSQL';
import ModalTrigger from '../../components/ModalTrigger';
import Loading from '../../components/Loading';
-const propTypes = {
- table: PropTypes.object,
- actions: PropTypes.object,
-};
+interface Column {
+ name: string;
+ keys?: { type: ColumnKeyTypeType }[];
+ type: string;
+}
-const defaultProps = {
- actions: {},
- table: null,
-};
+interface Table {
+ name: string;
+ partitions?: {
+ partitionQuery: string;
+ latest: object[];
+ };
+ indexes: object[];
+ selectStar: string;
+ view: string;
+ isMetadataLoading: boolean;
+ isExtraMetadataLoading: boolean;
+ columns: Column[];
+}
+
+interface TableElementProps {
+ table: Table;
+ actions: {
+ removeDataPreview(table: Table): void;
Review comment:
could we set these as possibly undefined as well?
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -17,31 +17,49 @@
* under the License.
*/
import React, { useState } from 'react';
-import PropTypes from 'prop-types';
import Collapse from 'src/components/Collapse';
import Card from 'src/components/Card';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, styled } from '@superset-ui/core';
import { debounce } from 'lodash';
import { Tooltip } from 'src/components/Tooltip';
-import Icons from 'src/components/Icons';
import CopyToClipboard from '../../components/CopyToClipboard';
import { IconTooltip } from '../../components/IconTooltip';
-import ColumnElement from './ColumnElement';
+import ColumnElement, { ColumnKeyTypeType } from './ColumnElement';
import ShowSQL from './ShowSQL';
import ModalTrigger from '../../components/ModalTrigger';
import Loading from '../../components/Loading';
-const propTypes = {
- table: PropTypes.object,
- actions: PropTypes.object,
-};
+interface Column {
+ name: string;
+ keys?: { type: ColumnKeyTypeType }[];
+ type: string;
+}
-const defaultProps = {
- actions: {},
- table: null,
-};
+interface Table {
+ name: string;
+ partitions?: {
+ partitionQuery: string;
+ latest: object[];
+ };
+ indexes: object[];
+ selectStar: string;
+ view: string;
+ isMetadataLoading: boolean;
+ isExtraMetadataLoading: boolean;
+ columns: Column[];
+}
+
+interface TableElementProps {
+ table: Table;
+ actions: {
+ removeDataPreview(table: Table): void;
Review comment:
are these supposed to be functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] corbinrobb commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
corbinrobb commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861811639
Whew! That's relieving, I got super worried for a moment there lol Thanks for everything! @eschutho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3fc350) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
+ Coverage 77.61% 77.74% +0.13%
==========================================
Files 965 966 +1
Lines 49503 49625 +122
Branches 6259 6315 +56
==========================================
+ Hits 38422 38583 +161
+ Misses 10881 10839 -42
- Partials 200 203 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.79% <100.00%> (+0.30%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.10% <100.00%> (ø)` | |
| [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `91.89% <0.00%> (-5.17%)` | :arrow_down: |
| [...hboard/components/nativeFilters/FilterBar/state.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL3N0YXRlLnRz) | `85.41% <0.00%> (-3.22%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.64% <0.00%> (-2.89%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryTable/index.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUvaW5kZXguanN4) | `61.64% <0.00%> (-2.65%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `70.03% <0.00%> (-0.55%)` | :arrow_down: |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `67.50% <0.00%> (-0.45%)` | :arrow_down: |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...d3fc350](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861056399
@AAfghahi @corbinrobb would you like me to merge when this passes tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r649298314
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -92,15 +107,15 @@ const TableElement = props => {
/>
);
}
- let latest = Object.entries(table.partitions?.latest || []).map(
+ const latest = Object.entries(table.partitions?.latest || []).map(
([key, value]) => `${key}=${value}`,
Review comment:
is this why you made key into string | number? Because this key is a different key than the one in props. It looks like key is always a number. But also that it isn't being pushed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861070340
/testeenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] corbinrobb commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
corbinrobb commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861076353
Thanks! @eschutho I am happy with merging it if you and @AAfghahi are!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r646874738
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -17,31 +17,58 @@
* under the License.
*/
import React, { useState } from 'react';
-import PropTypes from 'prop-types';
import Collapse from 'src/components/Collapse';
import Card from 'src/components/Card';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, styled } from '@superset-ui/core';
import { debounce } from 'lodash';
import { Tooltip } from 'src/components/Tooltip';
-import Icons from 'src/components/Icons';
import CopyToClipboard from '../../components/CopyToClipboard';
import { IconTooltip } from '../../components/IconTooltip';
-import ColumnElement from './ColumnElement';
+import ColumnElement, { ColumnKeyTypeType } from './ColumnElement';
import ShowSQL from './ShowSQL';
import ModalTrigger from '../../components/ModalTrigger';
import Loading from '../../components/Loading';
-const propTypes = {
- table: PropTypes.object,
- actions: PropTypes.object,
-};
+// I don't think this makes sense to have
+// Shouldn't be rendering component if table and actions are'nt passed in
+// ----------------------
+// const defaultProps = {
+// actions: {},
+// table: null,
+// };
+// ----------------------
-const defaultProps = {
- actions: {},
- table: null,
-};
+interface Column {
+ name: string;
+ keys?: { type: ColumnKeyTypeType }[];
+ type: string;
+}
+
+interface Table {
+ name: string;
+ partitions?: {
+ partitionQuery: string;
+ latest: object[];
+ };
+ indexes: object[];
+ selectStar: string;
+ view: string;
+ isMetadataLoading: boolean;
+ isExtraMetadataLoading: boolean;
+ columns: Column[];
+}
+
+interface TableElementProps {
+ table: Table;
Review comment:
```suggestion
table: Table | null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4071c19) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 4071c19 differs from pull request most recent head 80ca81a. Consider uploading reports for the commit 80ca81a to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
- Coverage 77.61% 77.57% -0.05%
==========================================
Files 965 967 +2
Lines 49503 49735 +232
Branches 6259 6353 +94
==========================================
+ Hits 38422 38582 +160
- Misses 10881 10949 +68
- Partials 200 204 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.44% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.10% <100.00%> (ø)` | |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-50.00%)` | :arrow_down: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `47.00% <0.00%> (-30.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `58.97% <0.00%> (-25.65%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `59.61% <0.00%> (-21.24%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `58.47% <0.00%> (-15.26%)` | :arrow_down: |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.96% <0.00%> (-12.91%)` | :arrow_down: |
| [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.39% <0.00%> (-9.81%)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...80ca81a](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] corbinrobb commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
corbinrobb commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r647783620
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -17,31 +17,49 @@
* under the License.
*/
import React, { useState } from 'react';
-import PropTypes from 'prop-types';
import Collapse from 'src/components/Collapse';
import Card from 'src/components/Card';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, styled } from '@superset-ui/core';
import { debounce } from 'lodash';
import { Tooltip } from 'src/components/Tooltip';
-import Icons from 'src/components/Icons';
import CopyToClipboard from '../../components/CopyToClipboard';
import { IconTooltip } from '../../components/IconTooltip';
-import ColumnElement from './ColumnElement';
+import ColumnElement, { ColumnKeyTypeType } from './ColumnElement';
import ShowSQL from './ShowSQL';
import ModalTrigger from '../../components/ModalTrigger';
import Loading from '../../components/Loading';
-const propTypes = {
- table: PropTypes.object,
- actions: PropTypes.object,
-};
+interface Column {
+ name: string;
+ keys?: { type: ColumnKeyTypeType }[];
+ type: string;
+}
-const defaultProps = {
- actions: {},
- table: null,
-};
+interface Table {
+ name: string;
+ partitions?: {
+ partitionQuery: string;
+ latest: object[];
+ };
+ indexes: object[];
+ selectStar: string;
+ view: string;
+ isMetadataLoading: boolean;
+ isExtraMetadataLoading: boolean;
+ columns: Column[];
+}
+
+interface TableElementProps {
+ table: Table;
+ actions: {
+ removeDataPreview(table: Table): void;
Review comment:
We could do that but on line 87 in the `removeTable` function it is expecting both the `removeDataPreview` and the `removeTable` actions. So I could add that they can be undefined but I would have to also add logic there to make sure they aren't undefined before invoking them. I can do that though! I just don't think it would make sense to render a table element that has a remove button that doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] corbinrobb commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
corbinrobb commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r651334616
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -53,16 +70,21 @@ const StyledSpan = styled.span`
const Fade = styled.div`
transition: all ${({ theme }) => theme.transitionTiming}s;
- opacity: ${props => (props.hovered ? 1 : 0)};
+ opacity: ${(props: { hovered: boolean }) => (props.hovered ? 1 : 0)};
`;
-const TableElement = props => {
+// Note about TableElement props:
+// The antd Collapse component is expecting its children to be `Collapse.Panel`s and
+// is quietly passing extra props that need to be on the panels for them to work correctly.
+// These props are not defined in their TypeScript type for Panel though because
+// this logic is happening in the Collapse component itself. We have gotten around the TypeScript
+// errors by using the rest and spread operators to pass the necessary extra props to the Panels.
+
Review comment:
Sounds good! I am removing the comment and adding the two other changes. I will push them all up momentarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861810021
You're right, @corbinrobb. That example didn't have anything to sort. I tested on a different list and it's working. I'll go ahead and merge. Thanks for the help on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r649248942
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -261,10 +270,14 @@ const TableElement = (props: TableElementProps) => {
return (
<Collapse.Panel
- {...props}
header={renderHeader()}
className="TableElement"
forceRender
+ isActive={isActive}
+ expandIcon={expandIcon}
+ onItemClick={onItemClick}
+ openMotion={openMotion}
+ panelKey={panelKey}
Review comment:
I love this, good job!
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -54,11 +54,14 @@ interface Table {
interface TableElementProps {
table: Table;
actions: {
- removeDataPreview(table: Table): void;
- removeTable(table: Table): void;
+ removeDataPreview: (table: Table) => void;
+ removeTable: (table: Table) => void;
};
isActive: boolean;
- key: string | number;
+ panelKey: string | number;
Review comment:
oh that's so weird that it can be a string or a number. Wild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36401d3) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **increase** coverage by `0.07%`.
> The diff coverage is `92.72%`.
> :exclamation: Current head 36401d3 differs from pull request most recent head d3fc350. Consider uploading reports for the commit d3fc350 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
+ Coverage 77.61% 77.68% +0.07%
==========================================
Files 965 965
Lines 49503 49541 +38
Branches 6259 6269 +10
==========================================
+ Hits 38422 38488 +66
+ Misses 10881 10850 -31
- Partials 200 203 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.64% <92.72%> (+0.16%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../components/Header/HeaderActionsDropdown/index.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9IZWFkZXJBY3Rpb25zRHJvcGRvd24vaW5kZXguanN4) | `68.42% <ø> (ø)` | |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `40.00% <ø> (ø)` | |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.60% <ø> (ø)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `88.67% <87.09%> (+88.67%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.20% <100.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `82.69% <100.00%> (+1.84%)` | :arrow_up: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `81.72% <100.00%> (+0.19%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...d3fc350](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3fc350) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d3fc350 differs from pull request most recent head 4071c19. Consider uploading reports for the commit 4071c19 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
+ Coverage 77.61% 77.74% +0.13%
==========================================
Files 965 966 +1
Lines 49503 49625 +122
Branches 6259 6315 +56
==========================================
+ Hits 38422 38583 +161
+ Misses 10881 10839 -42
- Partials 200 203 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.79% <100.00%> (+0.30%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.10% <100.00%> (ø)` | |
| [...nfigModal/FiltersConfigForm/getControlItemsMap.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL2dldENvbnRyb2xJdGVtc01hcC50c3g=) | `91.89% <0.00%> (-5.17%)` | :arrow_down: |
| [...hboard/components/nativeFilters/FilterBar/state.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL3N0YXRlLnRz) | `85.41% <0.00%> (-3.22%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `78.64% <0.00%> (-2.89%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryTable/index.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUvaW5kZXguanN4) | `61.64% <0.00%> (-2.65%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `70.03% <0.00%> (-0.55%)` | :arrow_down: |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `67.50% <0.00%> (-0.45%)` | :arrow_down: |
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...4071c19](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861835022
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r651322322
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -92,15 +114,15 @@ const TableElement = props => {
/>
);
}
- let latest = Object.entries(table.partitions?.latest || []).map(
+ const latest = Object.entries(table.partitions?.latest || []).map(
Review comment:
small nit, but if we're not going to use latest again, can we just define it once as
```
const latest = Object.entries(table.partitions?.latest || []).map(
([key, value]) => `${key}=${value}`,
).join('/');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r649253139
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -53,16 +70,14 @@ const StyledSpan = styled.span`
const Fade = styled.div`
transition: all ${({ theme }) => theme.transitionTiming}s;
- opacity: ${props => (props.hovered ? 1 : 0)};
+ opacity: ${(props: { hovered: boolean }) => (props.hovered ? 1 : 0)};
`;
-const TableElement = props => {
+const TableElement = ({ table, actions, key, ...props }: TableElementProps) => {
Review comment:
it still bothers me that I don't know all of the props being passed in here. But I agree that this is much more elegant.
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -17,31 +17,48 @@
* under the License.
*/
import React, { useState } from 'react';
-import PropTypes from 'prop-types';
import Collapse from 'src/components/Collapse';
import Card from 'src/components/Card';
import ButtonGroup from 'src/components/ButtonGroup';
import { t, styled } from '@superset-ui/core';
import { debounce } from 'lodash';
import { Tooltip } from 'src/components/Tooltip';
-import Icons from 'src/components/Icons';
import CopyToClipboard from '../../components/CopyToClipboard';
import { IconTooltip } from '../../components/IconTooltip';
-import ColumnElement from './ColumnElement';
+import ColumnElement, { ColumnKeyTypeType } from './ColumnElement';
import ShowSQL from './ShowSQL';
import ModalTrigger from '../../components/ModalTrigger';
import Loading from '../../components/Loading';
-const propTypes = {
- table: PropTypes.object,
- actions: PropTypes.object,
-};
+interface Column {
+ name: string;
+ keys?: { type: ColumnKeyTypeType }[];
+ type: string;
+}
-const defaultProps = {
- actions: {},
- table: null,
-};
+interface Table {
+ name: string;
+ partitions?: {
+ partitionQuery: string;
+ latest: object[];
+ };
+ indexes?: object[];
+ selectStar?: string;
+ view?: string;
+ isMetadataLoading: boolean;
+ isExtraMetadataLoading: boolean;
+ columns: Column[];
+}
+
+interface TableElementProps {
+ table: Table;
+ actions: {
+ removeDataPreview: (table: Table) => void;
+ removeTable: (table: Table) => void;
+ };
+ key: string | number;
Review comment:
This looks like it might just be a string? Are there places where it is used as a number? (though it is odd that it is a string, since a key should be a number. . .)
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -247,41 +256,17 @@ const TableElement = props => {
return metadata;
};
- const collapseExpandIcon = () => (
- <IconTooltip
- style={{
- position: 'fixed',
- right: '16px',
- left: 'auto',
- fontSize: '12px',
- transform: 'rotate(90deg)',
- display: 'flex',
- alignItems: 'center',
- }}
- aria-label="Collapse"
- tooltip={t(`${isActive ? 'Collapse' : 'Expand'} table preview`)}
- >
- <Icons.RightOutlined
- iconSize="s"
- style={isActive ? { transform: 'rotateY(180deg)' } : null}
- />
- </IconTooltip>
- );
-
return (
<Collapse.Panel
{...props}
+ key={key}
Review comment:
What do you get when console.log key? I am looking at the old component and it looks really weird.
but key is specifically being put in.
https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx#L191
Also, where is this panelKey thing coming from!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho merged pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho merged pull request #14978:
URL: https://github.com/apache/superset/pull/14978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4071c19) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
- Coverage 77.61% 77.57% -0.05%
==========================================
Files 965 967 +2
Lines 49503 49735 +232
Branches 6259 6353 +94
==========================================
+ Hits 38422 38582 +160
- Misses 10881 10949 +68
- Partials 200 204 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.44% <100.00%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.10% <100.00%> (ø)` | |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-50.00%)` | :arrow_down: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `47.00% <0.00%> (-30.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | `58.97% <0.00%> (-25.65%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `59.61% <0.00%> (-21.24%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `58.47% <0.00%> (-15.26%)` | :arrow_down: |
| [...nd/src/components/SupersetResourceSelect/index.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3VwZXJzZXRSZXNvdXJjZVNlbGVjdC9pbmRleC50c3g=) | `70.96% <0.00%> (-12.91%)` | :arrow_down: |
| [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [...nativeFilters/FilterBar/FilterSets/EditSection.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRWRpdFNlY3Rpb24udHN4) | `80.39% <0.00%> (-9.81%)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...4071c19](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r649289563
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -247,41 +256,17 @@ const TableElement = props => {
return metadata;
};
- const collapseExpandIcon = () => (
- <IconTooltip
- style={{
- position: 'fixed',
- right: '16px',
- left: 'auto',
- fontSize: '12px',
- transform: 'rotate(90deg)',
- display: 'flex',
- alignItems: 'center',
- }}
- aria-label="Collapse"
- tooltip={t(`${isActive ? 'Collapse' : 'Expand'} table preview`)}
- >
- <Icons.RightOutlined
- iconSize="s"
- style={isActive ? { transform: 'rotateY(180deg)' } : null}
- />
- </IconTooltip>
- );
-
return (
<Collapse.Panel
{...props}
+ key={key}
Review comment:
I pulled your branch and console logged key:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861070340
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r651324297
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -53,16 +70,21 @@ const StyledSpan = styled.span`
const Fade = styled.div`
transition: all ${({ theme }) => theme.transitionTiming}s;
- opacity: ${props => (props.hovered ? 1 : 0)};
+ opacity: ${(props: { hovered: boolean }) => (props.hovered ? 1 : 0)};
`;
-const TableElement = props => {
+// Note about TableElement props:
+// The antd Collapse component is expecting its children to be `Collapse.Panel`s and
+// is quietly passing extra props that need to be on the panels for them to work correctly.
+// These props are not defined in their TypeScript type for Panel though because
+// this logic is happening in the Collapse component itself. We have gotten around the TypeScript
+// errors by using the rest and spread operators to pass the necessary extra props to the Panels.
+
Review comment:
I think this comment makes sense, but the pattern below doesn't look confusing. I think it's ok to remove the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r649289563
##########
File path: superset-frontend/src/SqlLab/components/TableElement.tsx
##########
@@ -247,41 +256,17 @@ const TableElement = props => {
return metadata;
};
- const collapseExpandIcon = () => (
- <IconTooltip
- style={{
- position: 'fixed',
- right: '16px',
- left: 'auto',
- fontSize: '12px',
- transform: 'rotate(90deg)',
- display: 'flex',
- alignItems: 'center',
- }}
- aria-label="Collapse"
- tooltip={t(`${isActive ? 'Collapse' : 'Expand'} table preview`)}
- >
- <Icons.RightOutlined
- iconSize="s"
- style={isActive ? { transform: 'rotateY(180deg)' } : null}
- />
- </IconTooltip>
- );
-
return (
<Collapse.Panel
{...props}
+ key={key}
Review comment:
I pulled your branch and console logged key:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854939127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-861758236
@eschutho Ephemeral environment spinning up at http://52.37.150.225:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36401d3) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **increase** coverage by `0.07%`.
> The diff coverage is `92.72%`.
> :exclamation: Current head 36401d3 differs from pull request most recent head 1cad775. Consider uploading reports for the commit 1cad775 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
+ Coverage 77.61% 77.68% +0.07%
==========================================
Files 965 965
Lines 49503 49541 +38
Branches 6259 6269 +10
==========================================
+ Hits 38422 38488 +66
+ Misses 10881 10850 -31
- Partials 200 203 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.64% <92.72%> (+0.16%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../components/Header/HeaderActionsDropdown/index.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9IZWFkZXJBY3Rpb25zRHJvcGRvd24vaW5kZXguanN4) | `68.42% <ø> (ø)` | |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `40.00% <ø> (ø)` | |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.60% <ø> (ø)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `88.67% <87.09%> (+88.67%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.20% <100.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `82.69% <100.00%> (+1.84%)` | :arrow_up: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `81.72% <100.00%> (+0.19%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...1cad775](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14978:
URL: https://github.com/apache/superset/pull/14978#issuecomment-854957236
# [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14978](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36401d3) into [master](https://codecov.io/gh/apache/superset/commit/004a6d9e54fe55cd497c1b5c74a097c467e4caba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (004a6d9) will **increase** coverage by `0.07%`.
> The diff coverage is `92.72%`.
> :exclamation: Current head 36401d3 differs from pull request most recent head f422720. Consider uploading reports for the commit f422720 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14978 +/- ##
==========================================
+ Coverage 77.61% 77.68% +0.07%
==========================================
Files 965 965
Lines 49503 49541 +38
Branches 6259 6269 +10
==========================================
+ Hits 38422 38488 +66
+ Misses 10881 10850 -31
- Partials 200 203 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `72.64% <92.72%> (+0.16%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../components/Header/HeaderActionsDropdown/index.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9IZWFkZXJBY3Rpb25zRHJvcGRvd24vaW5kZXguanN4) | `68.42% <ø> (ø)` | |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `40.00% <ø> (ø)` | |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (ø)` | |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `56.60% <ø> (ø)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `88.67% <87.09%> (+88.67%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `56.06% <100.00%> (+2.83%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/components/TableElement.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC50c3g=) | `92.20% <100.00%> (ø)` | |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `82.69% <100.00%> (+1.84%)` | :arrow_up: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `81.72% <100.00%> (+0.19%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/14978/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [004a6d9...f422720](https://codecov.io/gh/apache/superset/pull/14978?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a change in pull request #14978: refactor: Convert TableElement to TypeScript
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #14978:
URL: https://github.com/apache/superset/pull/14978#discussion_r651318186
##########
File path: superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -134,6 +136,19 @@ export default class SqlEditorLeftBar extends React.PureComponent {
this.props.actions.addTable(this.props.queryEditor, tableName, schemaName);
}
+ renderExpandIconWithTooltip = ({ isActive }) => (
+ <IconTooltip
+ style={{ transform: 'rotate(90deg)' }}
Review comment:
can we use the css prop here and below instead of `style`? It's a pattern we've been migrating to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org