You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Or_Daniel@emc.com (JIRA)" <ji...@apache.org> on 2007/08/22 12:22:34 UTC
[jira] Commented: (LANG-353) Javadoc Example for EqualsBuilder is
questionable
[ https://issues.apache.org/jira/browse/LANG-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521750 ]
Or_Daniel@emc.com commented on LANG-353:
----------------------------------------
Registering to commons.dev added me automatically to
issues@commons.apache.org.
Unregistering did not remove me from issues@commons.apache.org.
How do I unregister
> Javadoc Example for EqualsBuilder is questionable
> -------------------------------------------------
>
> Key: LANG-353
> URL: https://issues.apache.org/jira/browse/LANG-353
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Christoph Kutzinski
> Priority: Minor
> Fix For: 2.4
>
>
> The Javadoc example for the class EqualsBuilder ist questionable:
> public boolean equals(Object obj) {
> if (obj instanceof MyClass == false) {
> return false;
> }
> ...
> The implementation with instanceof lacks guarantees like equals-symmetry (see e.g. http://www.agiledeveloper.com/articles/equals062002.htm for a discussion of the issue)
> The example should be changed to use getClass(). Attention: the solution in the link above is incomplete as it doesn't check for null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (LANG-353) Javadoc Example for EqualsBuilder is questionable
Posted by Henri Yandell <fl...@gmail.com>.
At a guess, email:
issues-unsubscribe@commons.apache.org
My reply will probably have unsubscribe info at the bottom. For some
reason the automated JIRA emails don't get that.
[I'm going to delete the comment below from JIRA as it's not pertinent
to the issue in question]
On 8/22/07, Or_Daniel@emc.com (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/LANG-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521750 ]
>
> Or_Daniel@emc.com commented on LANG-353:
> ----------------------------------------
>
> Registering to commons.dev added me automatically to
> issues@commons.apache.org.
> Unregistering did not remove me from issues@commons.apache.org.
>
> How do I unregister
>
>
> > Javadoc Example for EqualsBuilder is questionable
> > -------------------------------------------------
> >
> > Key: LANG-353
> > URL: https://issues.apache.org/jira/browse/LANG-353
> > Project: Commons Lang
> > Issue Type: Bug
> > Reporter: Christoph Kutzinski
> > Priority: Minor
> > Fix For: 2.4
> >
> >
> > The Javadoc example for the class EqualsBuilder ist questionable:
> > public boolean equals(Object obj) {
> > if (obj instanceof MyClass == false) {
> > return false;
> > }
> > ...
> > The implementation with instanceof lacks guarantees like equals-symmetry (see e.g. http://www.agiledeveloper.com/articles/equals062002.htm for a discussion of the issue)
> > The example should be changed to use getClass(). Attention: the solution in the link above is incomplete as it doesn't check for null
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>