You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/25 03:46:13 UTC

[GitHub] [incubator-hudi] comsir opened a new pull request #1131: [MINOR] fix typo

comsir opened a new pull request #1131: [MINOR] fix typo
URL: https://github.com/apache/incubator-hudi/pull/1131
 
 
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Fix typo， error message
   
   ## Brief change log
   
   Fix typo
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] comsir commented on a change in pull request #1131: [MINOR] fix typo

Posted by GitBox <gi...@apache.org>.
comsir commented on a change in pull request #1131: [MINOR] fix typo
URL: https://github.com/apache/incubator-hudi/pull/1131#discussion_r361264762
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/RocksDBDAO.java
 ##########
 @@ -121,7 +121,7 @@ protected void log(InfoLogLevel infoLogLevel, String logMsg) {
         managedDescriptorMap.put(familyNameFromDescriptor, descriptor);
       }
     } catch (RocksDBException | IOException re) {
-      LOG.error("Got exception opening rocks db instance ", re);
+      LOG.error("Got exception opening Rocks DB instance ", re);
 
 Review comment:
   thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1131: [MINOR] fix typo

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1131: [MINOR] fix typo
URL: https://github.com/apache/incubator-hudi/pull/1131#discussion_r361254119
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/RocksDBDAO.java
 ##########
 @@ -121,7 +121,7 @@ protected void log(InfoLogLevel infoLogLevel, String logMsg) {
         managedDescriptorMap.put(familyNameFromDescriptor, descriptor);
       }
     } catch (RocksDBException | IOException re) {
-      LOG.error("Got exception opening rocks db instance ", re);
+      LOG.error("Got exception opening Rocks DB instance ", re);
 
 Review comment:
   I would not call this a typo :) .. but sure.. casing makes sense. merging.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar merged pull request #1131: [MINOR] fix typo

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1131: [MINOR] fix typo
URL: https://github.com/apache/incubator-hudi/pull/1131
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services