[jira] [Commented] (IMPALA-8250) Impala crashes with -Xcheck:jni

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785105#comment-16785105 ] 

ASF subversion and git services commented on IMPALA-8250:
---------------------------------------------------------

Commit 10a400f10c66f0897f62c990a03013c1069f6110 in impala's branch refs/heads/master from Philip Zeyliger
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=10a400f ]

IMPALA-8250: Remove unused THROW_IF_ERROR_WITH_LOGGING, THROW_IF_EXC, and RETURN_IF_EXC.

These macros have no references, so removing them. Found while
investigating JNI warnings in IMPALA-8250.

The following one-liner does a hap-hazard job of finding similar issues.
There are relatively few left, and none of them seemed problematic.

  (for x in $(git grep '#define' be/src | grep -v be/src/kudu | grep -v be/src/gutil | grep -v be/src/thirdparty | grep -v be/src/transport/config.h | awk '{ print $2 }' | sed -e 's,(.*,,' | sort | uniq); do echo -n "$x "; git grep -e $x | wc -l; done) | awk '$2 == 1 { print }'

Note that some of the macros were broken, because they
called other JNI functions before calling ExceptionClear().

Change-Id: Ic63b498e0e4da57c7ec15cf1ad8070a6afdb3d96
Reviewed-on: http://gerrit.cloudera.org:8080/12658
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Impala crashes with -Xcheck:jni
> -------------------------------
>
>                 Key: IMPALA-8250
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8250
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Philip Zeyliger
>            Priority: Major
>
> The JVM has a checker for JNI usage, and Impala (and libhdfs) have some violations. This ticket captures figuring that out. At least one of the issues can crash Impala.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org