[jira] [Commented] (FLINK-5224) Improve UDTF: emit rows directly instead of buffering them

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821841#comment-15821841 ] 

ASF GitHub Bot commented on FLINK-5224:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/3118

    [FLINK-5224] [table] Improve UDTF: emit rows directly instead of buffering them

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    
    This PR is an improvement for user-defined table function in Flink TableAPI & SQL. I didn't add new tests because the existing tests are sufficient.
    
    The core design is code generating a `Collector` and register it into the instance of `TableFunction`, and emit the rows generated by the UDTF directly instead of buffering them.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink udtf-collector-FLINK-5224

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3118
    
----
commit 5e126a97bb26654048efa735c21e0daff136a6a2
Author: Jark Wu <wu...@alibaba-inc.com>
Date:   2017-01-13T13:53:49Z

    [FLINK-5224] [table] Improve UDTF: emit rows directly instead of buffering them

----


> Improve UDTF: emit rows directly instead of buffering them
> ----------------------------------------------------------
>
>                 Key: FLINK-5224
>                 URL: https://issues.apache.org/jira/browse/FLINK-5224
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> This needs to code generate a `Collector` and register it into instance of {{TableFunction}}, and emit the rows generated by the UDTF directly instead of buffering them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)