You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by zh...@apache.org on 2022/06/27 10:01:09 UTC

[incubator-devlake] branch main updated: fix: dalgorm record not found (#2359)

This is an automated email from the ASF dual-hosted git repository.

zhangliang2022 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


The following commit(s) were added to refs/heads/main by this push:
     new ac292ac9 fix: dalgorm record not found (#2359)
ac292ac9 is described below

commit ac292ac9ef5ea508fa6810e5ae94619cf62ba493
Author: abeizn <10...@users.noreply.github.com>
AuthorDate: Mon Jun 27 18:01:03 2022 +0800

    fix: dalgorm record not found (#2359)
---
 impl/dalgorm/dalgorm.go          | 3 ---
 plugins/jenkins/api/blueprint.go | 2 --
 2 files changed, 5 deletions(-)

diff --git a/impl/dalgorm/dalgorm.go b/impl/dalgorm/dalgorm.go
index a189d27c..f46d04f1 100644
--- a/impl/dalgorm/dalgorm.go
+++ b/impl/dalgorm/dalgorm.go
@@ -110,9 +110,6 @@ func (d *Dalgorm) All(dst interface{}, clauses ...dal.Clause) error {
 // First loads first matched row from database to `dst`, error will be returned if no records were found
 func (d *Dalgorm) First(dst interface{}, clauses ...dal.Clause) error {
 	err := buildTx(d.db, clauses).First(dst).Error
-	if err == gorm.ErrRecordNotFound {
-		return dal.ErrRecordNotFound
-	}
 	return err
 }
 
diff --git a/plugins/jenkins/api/blueprint.go b/plugins/jenkins/api/blueprint.go
index 122c9396..ba06af35 100644
--- a/plugins/jenkins/api/blueprint.go
+++ b/plugins/jenkins/api/blueprint.go
@@ -19,7 +19,6 @@ package api
 
 import (
 	"encoding/json"
-	"fmt"
 
 	"github.com/apache/incubator-devlake/plugins/core"
 	"github.com/apache/incubator-devlake/plugins/helper"
@@ -34,7 +33,6 @@ func MakePipelinePlan(subtaskMetas []core.SubTaskMeta, connectionId uint64, scop
 		taskOptions := make(map[string]interface{})
 		err = json.Unmarshal(scopeElem.Options, &taskOptions)
 		if err != nil {
-			fmt.Println("1111")
 			return nil, err
 		}
 		taskOptions["connectionId"] = connectionId