You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/25 13:03:59 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #19227: Fix GCS system tests

potiuk commented on a change in pull request #19227:
URL: https://github.com/apache/airflow/pull/19227#discussion_r756872151



##########
File path: tests/providers/google/cloud/operators/test_gcs_system.py
##########
@@ -22,26 +22,49 @@
 from tests.test_utils.gcp_system_helpers import CLOUD_DAG_FOLDER, GoogleSystemTest, provide_gcp_context
 
 
+@pytest.fixture(scope="module")
+def helper():
+    return GcsSystemTestHelper()

Review comment:
       Helper is as good as it can get. I also do not like general "Util, Helper, Manager, Processor" but if you look at Airflow code we have quite a bunch of those everywhere (and as much as we fight it - there ARE cases where they are needed and actually usually in tests, I'd be far more relaxed to have those).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org