You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by ji...@apache.org on 2023/01/19 10:12:54 UTC
[incubator-hugegraph] branch fix-license created (now 36949740f)
This is an automated email from the ASF dual-hosted git repository.
jin pushed a change to branch fix-license
in repository https://gitbox.apache.org/repos/asf/incubator-hugegraph.git
at 36949740f refact: mark TODO in the license problem code & use standard UTF-8
This branch includes the following new commits:
new 36949740f refact: mark TODO in the license problem code & use standard UTF-8
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[incubator-hugegraph] 01/01: refact: mark TODO in the license problem code & use standard UTF-8
Posted by ji...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jin pushed a commit to branch fix-license
in repository https://gitbox.apache.org/repos/asf/incubator-hugegraph.git
commit 36949740f46f90700501bc200347a4046355363f
Author: imbajin <ji...@apache.org>
AuthorDate: Thu Jan 19 17:40:31 2023 +0800
refact: mark TODO in the license problem code & use standard UTF-8
also fix some tiny problem
---
.../org/apache/hugegraph/api/job/GremlinAPI.java | 2 +-
.../backend/store/cassandra/CassandraShard.java | 5 ++-
.../apache/hugegraph/analyzer/AnsjAnalyzer.java | 3 +-
.../apache/hugegraph/analyzer/HanLPAnalyzer.java | 1 +
.../org/apache/hugegraph/analyzer/IKAnalyzer.java | 1 +
.../apache/hugegraph/analyzer/JcsegAnalyzer.java | 1 +
.../apache/hugegraph/analyzer/JiebaAnalyzer.java | 1 +
.../apache/hugegraph/analyzer/MMSeg4JAnalyzer.java | 1 +
.../apache/hugegraph/analyzer/SmartCNAnalyzer.java | 1 +
.../hugegraph/backend/id/SnowflakeIdGenerator.java | 3 +-
.../traversal/optimize/HugeScriptTraversal.java | 17 +++----
.../java/org/apache/hugegraph/type/Nameable.java | 3 +-
.../apache/hugegraph/type/define/Cardinality.java | 9 ++--
.../org/apache/hugegraph/util/CompressUtil.java | 1 +
.../java/org/apache/hugegraph/util/GZipUtil.java | 1 +
.../org/apache/hugegraph/util/StringEncoding.java | 52 ++++++++++------------
.../hugegraph/tinkerpop/ProcessBasicSuite.java | 12 +++--
.../hugegraph/tinkerpop/StructureBasicSuite.java | 8 ++--
18 files changed, 62 insertions(+), 60 deletions(-)
diff --git a/hugegraph-api/src/main/java/org/apache/hugegraph/api/job/GremlinAPI.java b/hugegraph-api/src/main/java/org/apache/hugegraph/api/job/GremlinAPI.java
index aef8fbcfb..2686daf12 100644
--- a/hugegraph-api/src/main/java/org/apache/hugegraph/api/job/GremlinAPI.java
+++ b/hugegraph-api/src/main/java/org/apache/hugegraph/api/job/GremlinAPI.java
@@ -150,7 +150,7 @@ public class GremlinAPI extends API {
return firstLine;
}
- /*
+ /* TODO: ensure the refer is valid
* Reference https://stackoverflow.com/questions/3576754/truncating-strings-by-bytes
*/
CharsetDecoder decoder = charset.newDecoder();
diff --git a/hugegraph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java b/hugegraph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java
index 1bb218e18..c5734f62e 100644
--- a/hugegraph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java
+++ b/hugegraph-cassandra/src/main/java/org/apache/hugegraph/backend/store/cassandra/CassandraShard.java
@@ -56,12 +56,13 @@ import com.google.common.collect.ImmutableMap;
* CassandraShard is used for cassandra scanning operations.
* Each shard represents a range of tokens for a node.
* Reading data from a given shard does not cross multiple nodes.
+ * <p>
* Refer to AbstractColumnFamilyInputFormat from:
* <a href="https://github.com/2013Commons/hive-cassandra/">...</a>
*/
public class CassandraShard {
- // The minimal shard size should >= 1M to prevent too many number of shards
+ /** The minimal shard size should >= 1M to prevent too many number of shards */
private static final int MIN_SHARD_SIZE = (int) Bytes.MB;
private CassandraSessionPool.Session session;
@@ -228,7 +229,7 @@ public class CassandraShard {
tokenRange.getEnd().toString());
Row row = resultSet.one();
- long meanPartitionSize = 0L;
+ long meanPartitionSize;
long partitionsCount = 0L;
long splitCount = 0L;
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/AnsjAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/AnsjAnalyzer.java
index 84fd950aa..96a1d142b 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/AnsjAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/AnsjAnalyzer.java
@@ -32,6 +32,7 @@ import org.apache.hugegraph.util.InsertionOrderUtil;
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class AnsjAnalyzer implements Analyzer {
@@ -56,7 +57,7 @@ public class AnsjAnalyzer implements Analyzer {
@Override
public Set<String> segment(String text) {
- Result terms = null;
+ Result terms;
switch (this.analysis) {
case "BaseAnalysis":
terms = BaseAnalysis.parse(text);
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/HanLPAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/HanLPAnalyzer.java
index 393bd027e..af068362b 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/HanLPAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/HanLPAnalyzer.java
@@ -33,6 +33,7 @@ import com.hankcs.hanlp.tokenizer.SpeedTokenizer;
import com.hankcs.hanlp.tokenizer.StandardTokenizer;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class HanLPAnalyzer implements Analyzer {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/IKAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/IKAnalyzer.java
index 30cb91dd3..ba66de1f3 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/IKAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/IKAnalyzer.java
@@ -30,6 +30,7 @@ import org.apache.hugegraph.util.InsertionOrderUtil;
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class IKAnalyzer implements Analyzer {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JcsegAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JcsegAnalyzer.java
index 9e0d8998f..97a3239e9 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JcsegAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JcsegAnalyzer.java
@@ -33,6 +33,7 @@ import org.apache.hugegraph.util.InsertionOrderUtil;
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class JcsegAnalyzer implements Analyzer {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JiebaAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JiebaAnalyzer.java
index 22cb5e50f..e39206fe8 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JiebaAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JiebaAnalyzer.java
@@ -27,6 +27,7 @@ import com.huaban.analysis.jieba.JiebaSegmenter;
import com.huaban.analysis.jieba.SegToken;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class JiebaAnalyzer implements Analyzer {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/MMSeg4JAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/MMSeg4JAnalyzer.java
index 73e6b31ed..6e92032d2 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/MMSeg4JAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/MMSeg4JAnalyzer.java
@@ -34,6 +34,7 @@ import com.chenlb.mmseg4j.Word;
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class MMSeg4JAnalyzer implements Analyzer {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/SmartCNAnalyzer.java b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/SmartCNAnalyzer.java
index f6b4d7117..3bf97ad3f 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/SmartCNAnalyzer.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/SmartCNAnalyzer.java
@@ -29,6 +29,7 @@ import org.apache.lucene.analysis.tokenattributes.CharTermAttribute;
import org.apache.hugegraph.util.InsertionOrderUtil;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class SmartCNAnalyzer implements Analyzer {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java b/hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java
index ba2780931..124b257bd 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java
@@ -94,7 +94,8 @@ public class SnowflakeIdGenerator extends IdGenerator {
return this.generate();
}
- /*
+ /**
+ * TODO: lack LICENSE reference & seems need move to header
* Copyright 2010-2012 Twitter, Inc.
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java b/hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java
index d6d8de4cf..341931676 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java
@@ -32,6 +32,7 @@ import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSo
import org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal;
/**
+ * TODO: lack LICENSE reference
* ScriptTraversal encapsulates a {@link ScriptEngine} and a script which is
* compiled into a {@link Traversal} at {@link Admin#applyStrategies()}.
*
@@ -51,10 +52,8 @@ public final class HugeScriptTraversal<S, E> extends DefaultTraversal<S, E> {
private Object result;
- public HugeScriptTraversal(TraversalSource traversalSource,
- String language, String script,
- Map<String, Object> bindings,
- Map<String, String> aliases) {
+ public HugeScriptTraversal(TraversalSource traversalSource, String language, String script,
+ Map<String, Object> bindings, Map<String, String> aliases) {
this.graph = traversalSource.getGraph();
this.language = language;
this.script = script;
@@ -73,8 +72,7 @@ public final class HugeScriptTraversal<S, E> extends DefaultTraversal<S, E> {
@Override
public void applyStrategies() throws IllegalStateException {
- ScriptEngine engine =
- SingleGremlinScriptEngineManager.get(this.language);
+ ScriptEngine engine = SingleGremlinScriptEngineManager.get(this.language);
Bindings bindings = engine.createBindings();
bindings.putAll(this.bindings);
@@ -92,9 +90,8 @@ public final class HugeScriptTraversal<S, E> extends DefaultTraversal<S, E> {
for (Map.Entry<String, String> entry : this.aliases.entrySet()) {
Object value = bindings.get(entry.getValue());
if (value == null) {
- throw new IllegalArgumentException(String.format(
- "Invalid aliase '%s':'%s'",
- entry.getKey(), entry.getValue()));
+ throw new IllegalArgumentException(String.format("Invalid alias '%s':'%s'",
+ entry.getKey(), entry.getValue()));
}
bindings.put(entry.getKey(), value);
}
@@ -103,7 +100,7 @@ public final class HugeScriptTraversal<S, E> extends DefaultTraversal<S, E> {
Object result = engine.eval(this.script, bindings);
if (result instanceof Admin) {
- @SuppressWarnings({ "unchecked", "resource" })
+ @SuppressWarnings({ "unchecked"})
Admin<S, E> traversal = (Admin<S, E>) result;
traversal.getSideEffects().mergeInto(this.sideEffects);
traversal.getSteps().forEach(this::addStep);
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java b/hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java
index ad9de8113..536c66872 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java
@@ -1,4 +1,4 @@
-/*
+/* TODO: remove the APL2 license header?
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with this
* work for additional information regarding copyright ownership. The ASF
@@ -18,6 +18,7 @@
package org.apache.hugegraph.type;
/**
+ * TODO: lack license header & LICENSE reference
* Represents an entity that can be uniquely identified by a String name.
*
* @author Matthias Broecheler (me@matthiasb.com)
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java b/hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java
index b6d78dab6..ba156435e 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java
@@ -20,6 +20,7 @@ package org.apache.hugegraph.type.define;
import org.apache.tinkerpop.gremlin.structure.VertexProperty;
/**
+ * TODO: lack license header & LICENSE reference
* The cardinality of the values associated with given key for a particular element.
*
* @author Matthias Broecheler (me@matthiasb.com)
@@ -42,8 +43,8 @@ public enum Cardinality implements SerialEnum {
*/
SET(3, "set");
- private byte code = 0;
- private String name = null;
+ private final byte code;
+ private final String name;
static {
SerialEnum.register(Cardinality.class);
@@ -81,8 +82,8 @@ public enum Cardinality implements SerialEnum {
case set:
return SET;
default:
- throw new AssertionError(String.format(
- "Unrecognized cardinality: '%s'", cardinality));
+ throw new AssertionError(String.format("Unrecognized cardinality: '%s'",
+ cardinality));
}
}
}
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/util/CompressUtil.java b/hugegraph-core/src/main/java/org/apache/hugegraph/util/CompressUtil.java
index 7fcbeea82..954dc9110 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/util/CompressUtil.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/util/CompressUtil.java
@@ -57,6 +57,7 @@ import net.jpountz.lz4.LZ4FastDecompressor;
public final class CompressUtil {
/**
+ * TODO: ensure the refer is valid & clear
* Reference: https://mkyong.com/java/how-to-create-tar-gz-in-java/
*/
public static void compressTar(String inputDir, String outputFile,
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/util/GZipUtil.java b/hugegraph-core/src/main/java/org/apache/hugegraph/util/GZipUtil.java
index e07b0d5b8..7a9dcd426 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/util/GZipUtil.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/util/GZipUtil.java
@@ -27,6 +27,7 @@ import org.apache.hugegraph.backend.BackendException;
import org.apache.hugegraph.backend.serializer.BytesBuffer;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://dzone.com/articles/how-compress-and-uncompress
*/
public final class GZipUtil {
diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java b/hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java
index 2461765fa..65e9ecc97 100644
--- a/hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java
+++ b/hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java
@@ -17,19 +17,22 @@
package org.apache.hugegraph.util;
-import java.io.UnsupportedEncodingException;
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+import java.io.IOException;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.Base64;
import java.util.UUID;
-import org.mindrot.jbcrypt.BCrypt;
-
import org.apache.hugegraph.HugeException;
import org.apache.hugegraph.backend.serializer.BytesBuffer;
+import org.mindrot.jbcrypt.BCrypt;
+
import com.google.common.base.CharMatcher;
/**
+ * TODO: lack license header & LICENSE reference
* @author Matthias Broecheler (me@matthiasb.com)
* @author HugeGraph Authors
*/
@@ -52,7 +55,7 @@ public final class StringEncoding {
private static final Base64.Encoder BASE64_ENCODER = Base64.getEncoder();
private static final Base64.Decoder BASE64_DECODER = Base64.getDecoder();
- // Similar to {@link StringSerializer}
+ /** Similar to {@link StringSerializer} */
public static int writeAsciiString(byte[] array, int offset, String value) {
E.checkArgument(CharMatcher.ascii().matchesAllOf(value),
"'%s' must be ASCII string", value);
@@ -68,7 +71,8 @@ public final class StringEncoding {
assert c <= 127;
byte b = (byte) c;
if (++i == len) {
- b |= 0x80; // End marker
+ // End marker
+ b |= 0x80;
}
array[offset++] = b;
} while (i < len);
@@ -78,7 +82,7 @@ public final class StringEncoding {
public static String readAsciiString(byte[] array, int offset) {
StringBuilder sb = new StringBuilder();
- int c = 0;
+ int c;
do {
c = 0xFF & array[offset++];
if (c != 0x80) {
@@ -95,33 +99,21 @@ public final class StringEncoding {
}
public static byte[] encode(String value) {
- try {
- return value.getBytes("UTF-8");
- } catch (UnsupportedEncodingException e) {
- throw new HugeException("Failed to encode string", e);
- }
+ return value.getBytes(UTF_8);
}
public static String decode(byte[] bytes) {
if (bytes.length == 0) {
return STRING_EMPTY;
}
- try {
- return new String(bytes, "UTF-8");
- } catch (UnsupportedEncodingException e) {
- throw new HugeException("Failed to decode string", e);
- }
+ return new String(bytes, UTF_8);
}
public static String decode(byte[] bytes, int offset, int length) {
if (length == 0) {
return STRING_EMPTY;
}
- try {
- return new String(bytes, offset, length, "UTF-8");
- } catch (UnsupportedEncodingException e) {
- throw new HugeException("Failed to decode string", e);
- }
+ return new String(bytes, offset, length, UTF_8);
}
public static String encodeBase64(byte[] bytes) {
@@ -140,9 +132,11 @@ public final class StringEncoding {
}
public static byte[] compress(String value, float bufferRatio) {
- BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE,
- bufferRatio);
- return buf.bytes();
+ try (BytesBuffer buf = LZ4Util.compress(encode(value), BLOCK_SIZE, bufferRatio)) {
+ return buf.bytes();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
}
public static String decompress(byte[] value) {
@@ -150,8 +144,11 @@ public final class StringEncoding {
}
public static String decompress(byte[] value, float bufferRatio) {
- BytesBuffer buf = LZ4Util.decompress(value, BLOCK_SIZE, bufferRatio);
- return decode(buf.array(), 0, buf.position());
+ try (BytesBuffer buf = LZ4Util.decompress(value, BLOCK_SIZE, bufferRatio)) {
+ return decode(buf.array(), 0, buf.position());
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
}
public static String hashPassword(String password) {
@@ -180,8 +177,7 @@ public final class StringEncoding {
return UUID.fromString(value);
}
// UUID represented by hex string
- E.checkArgument(value.length() == 32,
- "Invalid UUID string: %s", value);
+ E.checkArgument(value.length() == 32, "Invalid UUID string: %s", value);
String high = value.substring(0, 16);
String low = value.substring(16);
return new UUID(Long.parseUnsignedLong(high, 16),
diff --git a/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/ProcessBasicSuite.java b/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/ProcessBasicSuite.java
index 16b202409..a8c4b4722 100644
--- a/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/ProcessBasicSuite.java
+++ b/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/ProcessBasicSuite.java
@@ -98,6 +98,7 @@ import org.junit.runners.model.Statement;
import org.apache.hugegraph.dist.RegisterUtil;
/**
+ * TODO: lack license header & LICENSE reference
* Standard process test suite for tinkerpop graph
*
* @author Stephen Mallette (http://stephen.genoprime.com)
@@ -201,7 +202,7 @@ public class ProcessBasicSuite extends AbstractGremlinSuite {
* A list of the minimum set of base tests that
* Gremlin flavors should implement to be compliant with Gremlin.
*/
- private static final Class<?>[] TESTS_TO_ENFORCE = new Class<?>[] {
+ private static final Class<?>[] TESTS_TO_ENFORCE = new Class<?>[]{
// branch
BranchTest.class,
ChooseTest.class,
@@ -267,17 +268,14 @@ public class ProcessBasicSuite extends AbstractGremlinSuite {
};
public ProcessBasicSuite(final Class<?> klass,
- final RunnerBuilder builder)
- throws InitializationError {
+ final RunnerBuilder builder) throws InitializationError {
super(klass, builder, ALL_TESTS, TESTS_TO_ENFORCE, true,
TraversalEngine.Type.STANDARD);
RegisterUtil.registerBackends();
}
- public ProcessBasicSuite(final Class<?> klass,
- final RunnerBuilder builder,
- final Class<?>[] testsToExecute)
- throws InitializationError {
+ public ProcessBasicSuite(final Class<?> klass, final RunnerBuilder builder,
+ final Class<?>[] testsToExecute) throws InitializationError {
super(klass, builder, testsToExecute, TESTS_TO_ENFORCE, true,
TraversalEngine.Type.STANDARD);
RegisterUtil.registerBackends();
diff --git a/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/StructureBasicSuite.java b/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/StructureBasicSuite.java
index a01cb6c07..b3e14a30c 100644
--- a/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/StructureBasicSuite.java
+++ b/hugegraph-test/src/main/java/org/apache/hugegraph/tinkerpop/StructureBasicSuite.java
@@ -17,7 +17,7 @@
package org.apache.hugegraph.tinkerpop;
-import org.apache.commons.configuration.ConfigurationException;
+import org.apache.hugegraph.dist.RegisterUtil;
import org.apache.tinkerpop.gremlin.AbstractGremlinSuite;
import org.apache.tinkerpop.gremlin.GraphManager;
import org.apache.tinkerpop.gremlin.GraphProvider;
@@ -54,9 +54,8 @@ import org.junit.runners.model.InitializationError;
import org.junit.runners.model.RunnerBuilder;
import org.junit.runners.model.Statement;
-import org.apache.hugegraph.dist.RegisterUtil;
-
/**
+ * TODO: lack license header & LICENSE reference
* Standard structure test suite for tinkerpop graph
*
* @author Stephen Mallette (http://stephen.genoprime.com)
@@ -100,8 +99,7 @@ public class StructureBasicSuite extends AbstractGremlinSuite {
public StructureBasicSuite(final Class<?> klass,
final RunnerBuilder builder)
- throws InitializationError,
- ConfigurationException {
+ throws InitializationError {
super(klass, builder, ALL_TESTS, null, true,
TraversalEngine.Type.STANDARD);