You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2007/08/08 08:38:29 UTC
svn commit: r563769 -
/myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/FacesServlet.java
Author: mmarinschek
Date: Tue Aug 7 23:38:28 2007
New Revision: 563769
URL: http://svn.apache.org/viewvc?view=rev&rev=563769
Log:
refactored generation of faces-context out into a separate private method (often people copy/paste the FacesServlet to do some special stuff, even though this is not the best form of reuse, having a marker method for something which changes often might help them with determining what needs to be copied over the next time)
Modified:
myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/FacesServlet.java
Modified: myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/FacesServlet.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/FacesServlet.java?view=diff&rev=563769&r1=563768&r2=563769
==============================================================================
--- myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/FacesServlet.java (original)
+++ myfaces/core/branches/1_2_1/api/src/main/java/javax/faces/webapp/FacesServlet.java Tue Aug 7 23:38:28 2007
@@ -132,11 +132,9 @@
}
if(log.isTraceEnabled()) log.trace("service begin");
- FacesContext facesContext
- = _facesContextFactory.getFacesContext(_servletConfig.getServletContext(),
- request,
- response,
- _lifecycle);
+
+ FacesContext facesContext = prepareFacesContext(request, response);
+
try {
_lifecycle.execute(facesContext);
_lifecycle.render(facesContext);
@@ -194,5 +192,14 @@
return defaultVal;
return (initParameter.equalsIgnoreCase("on") || initParameter.equals("1") || initParameter.equalsIgnoreCase("true"));
+ }
+
+ private FacesContext prepareFacesContext(ServletRequest request, ServletResponse response) {
+ FacesContext facesContext
+ = _facesContextFactory.getFacesContext(_servletConfig.getServletContext(),
+ request,
+ response,
+ _lifecycle);
+ return facesContext;
}
}