You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2017/11/09 15:55:43 UTC
[PROPOSAL] New module log4j-jetty
I would like to propose we add a new module called log4j-jetty whose sole
purpose is to implement org.eclipse.jetty.util.log.Logger
There is a way to get Log4j 1 and 2 to work with Jetty but it has to go
through Slf4j. I'd rather go directly.
Thoughts?
Gary
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 9, 2017 at 12:09 PM, Matt Sicker <bo...@gmail.com> wrote:
> On 9 November 2017 at 11:34, Gary Gregory <ga...@gmail.com> wrote:
>
> > I do not want to drag
> > Tomcat down into my local repo or on my class path in my IDE just
> because I
> > am depending on log4j-appserver's one class for Jetty logging.
> >
>
> There are certain dependencies in use already that bring in half the
> internet (e.g., any Hadoop-related dependencies), so I wouldn't worry too
> much about it. ;)
>
Since we are going the way of smaller modules with focused deps, I thought
this would be a good thing.
Gary
>
> --
> Matt Sicker <bo...@gmail.com>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Mikael Ståldal <mi...@apache.org>.
On 2017-11-09 20:09, Matt Sicker wrote:
> On 9 November 2017 at 11:34, Gary Gregory <ga...@gmail.com> wrote:
>
>> I do not want to drag
>> Tomcat down into my local repo or on my class path in my IDE just because I
>> am depending on log4j-appserver's one class for Jetty logging.
>>
>
> There are certain dependencies in use already that bring in half the
> internet (e.g., any Hadoop-related dependencies), so I wouldn't worry too
> much about it. ;)
I don't think we should contribute in making it worse.
https://en.wikipedia.org/wiki/Broken_windows_theory
Re: [PROPOSAL] New module log4j-jetty
Posted by Matt Sicker <bo...@gmail.com>.
On 9 November 2017 at 11:34, Gary Gregory <ga...@gmail.com> wrote:
> I do not want to drag
> Tomcat down into my local repo or on my class path in my IDE just because I
> am depending on log4j-appserver's one class for Jetty logging.
>
There are certain dependencies in use already that bring in half the
internet (e.g., any Hadoop-related dependencies), so I wouldn't worry too
much about it. ;)
--
Matt Sicker <bo...@gmail.com>
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 9, 2017 at 3:33 PM, Gary Gregory <ga...@gmail.com> wrote:
> On Thu, Nov 9, 2017 at 3:32 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>>
>> > On Nov 9, 2017, at 2:34 PM, Gary Gregory <ga...@gmail.com>
>> wrote:
>> >
>> > On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers <ralph.goers@dslextreme.com
>> >
>> > wrote:
>> >
>> >> Every module equates to another jar. I just don’t see why we need a jar
>> >> for one class where a jar with 2 (as well as classes for other app
>> servers)
>> >> will serve equally as well.
>> >>
>> >
>> > First, thank you for being patient here and continuing to entertain this
>> > idea :-) So much can get lost in emails.
>> >
>> > The case of app servers is a great one because these are usually huge
>> > complex beasts with sometimes lots of dependencies.
>> >
>> > I do not think we want to end up with a kitchen sink app server module.
>> > From a developer's experience POV, I would never want my tooling (like
>> > Maven) to end up downloading and configuring in a project jars from a
>> bunch
>> > of app servers and their dependencies. Especially since any single
>> > application will likely only use a single app server (like the one I am
>> > working on now, we are using Jetty and that's it.)
>> >
>> > Gary
>>
>> I don’t think this is ever going to happen. As a user, you will download
>> log4j-appserver as a dependency and everything else should be marked as
>> provided. If you are using Jetty then the tomcat stuff will just be ignored.
>>
>> Frankly I am expecting that there won’t be many classes per app server.
>> Typically, it is just what is needed to bind the app server’s logging to
>> log4j. It is possible we might have lookup’s specific to the platform, but
>> I would expect we would have an easy way to determine which ones are
>> appropriate and which aren’t.
>>
>
> OK, I'll tuck in the Jetty code in log4j-appserver.
>
Finally got around to it. Done.
Gary
>
> Gary
>
>
>>
>> Ralph
>>
>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 9, 2017 at 3:32 PM, Ralph Goers <ra...@dslextreme.com>
wrote:
>
> > On Nov 9, 2017, at 2:34 PM, Gary Gregory <ga...@gmail.com> wrote:
> >
> > On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
> > wrote:
> >
> >> Every module equates to another jar. I just don’t see why we need a jar
> >> for one class where a jar with 2 (as well as classes for other app
> servers)
> >> will serve equally as well.
> >>
> >
> > First, thank you for being patient here and continuing to entertain this
> > idea :-) So much can get lost in emails.
> >
> > The case of app servers is a great one because these are usually huge
> > complex beasts with sometimes lots of dependencies.
> >
> > I do not think we want to end up with a kitchen sink app server module.
> > From a developer's experience POV, I would never want my tooling (like
> > Maven) to end up downloading and configuring in a project jars from a
> bunch
> > of app servers and their dependencies. Especially since any single
> > application will likely only use a single app server (like the one I am
> > working on now, we are using Jetty and that's it.)
> >
> > Gary
>
> I don’t think this is ever going to happen. As a user, you will download
> log4j-appserver as a dependency and everything else should be marked as
> provided. If you are using Jetty then the tomcat stuff will just be ignored.
>
> Frankly I am expecting that there won’t be many classes per app server.
> Typically, it is just what is needed to bind the app server’s logging to
> log4j. It is possible we might have lookup’s specific to the platform, but
> I would expect we would have an easy way to determine which ones are
> appropriate and which aren’t.
>
OK, I'll tuck in the Jetty code in log4j-appserver.
Gary
>
> Ralph
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Ralph Goers <ra...@dslextreme.com>.
> On Nov 9, 2017, at 2:34 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> Every module equates to another jar. I just don’t see why we need a jar
>> for one class where a jar with 2 (as well as classes for other app servers)
>> will serve equally as well.
>>
>
> First, thank you for being patient here and continuing to entertain this
> idea :-) So much can get lost in emails.
>
> The case of app servers is a great one because these are usually huge
> complex beasts with sometimes lots of dependencies.
>
> I do not think we want to end up with a kitchen sink app server module.
> From a developer's experience POV, I would never want my tooling (like
> Maven) to end up downloading and configuring in a project jars from a bunch
> of app servers and their dependencies. Especially since any single
> application will likely only use a single app server (like the one I am
> working on now, we are using Jetty and that's it.)
>
> Gary
I don’t think this is ever going to happen. As a user, you will download log4j-appserver as a dependency and everything else should be marked as provided. If you are using Jetty then the tomcat stuff will just be ignored.
Frankly I am expecting that there won’t be many classes per app server. Typically, it is just what is needed to bind the app server’s logging to log4j. It is possible we might have lookup’s specific to the platform, but I would expect we would have an easy way to determine which ones are appropriate and which aren’t.
Ralph
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Nov 9, 2017 at 1:49 PM, Ralph Goers <ra...@dslextreme.com>
wrote:
> Every module equates to another jar. I just don’t see why we need a jar
> for one class where a jar with 2 (as well as classes for other app servers)
> will serve equally as well.
>
First, thank you for being patient here and continuing to entertain this
idea :-) So much can get lost in emails.
The case of app servers is a great one because these are usually huge
complex beasts with sometimes lots of dependencies.
I do not think we want to end up with a kitchen sink app server module.
From a developer's experience POV, I would never want my tooling (like
Maven) to end up downloading and configuring in a project jars from a bunch
of app servers and their dependencies. Especially since any single
application will likely only use a single app server (like the one I am
working on now, we are using Jetty and that's it.)
Gary
> Ralph
>
> > On Nov 9, 2017, at 1:16 PM, Gary Gregory <ga...@gmail.com> wrote:
> >
> > It seems to me that what repo this lives in is an orthogonal concern. We
> > already have plenty of repos IMO, I don't want to track another one, but
> > hey, that's just me. If log4j-appserver is OK in the main repo, so should
> > log4j-jetty.
> >
> > Gary
> >
> > On Thu, Nov 9, 2017 at 1:07 PM, Ralph Goers <ra...@dslextreme.com>
> > wrote:
> >
> >> If you want a specific log4-jetty than we should create a
> log4j-appserver
> >> repo and make log4j-tomcat and log4j-jetty there. Otherwise just put it
> in
> >> log4j-appserver with a provided dependency.
> >>
> >> Ralph
> >>
> >>> On Nov 9, 2017, at 11:54 AM, Gary Gregory <ga...@gmail.com>
> >> wrote:
> >>>
> >>> How about we rename log4j-appserver to log4j-tomcat and add
> log4j-jetty?
> >>>
> >>> Gary
> >>>
> >>> On Thu, Nov 9, 2017 at 10:45 AM, Ralph Goers <
> ralph.goers@dslextreme.com
> >>>
> >>> wrote:
> >>>
> >>>> Oops. It should be marked as provided. Almost the same effect though.
> >>>>
> >>>> Ralph
> >>>>
> >>>>> On Nov 9, 2017, at 10:44 AM, Ralph Goers <ralph.goers@dslextreme.com
> >
> >>>> wrote:
> >>>>>
> >>>>> The dependency on Tomcat should have been marked optional. That is my
> >>>> mistake.
> >>>>>
> >>>>> Ralph
> >>>>>
> >>>>>> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com>
> >>>> wrote:
> >>>>>>
> >>>>>> What about our theme/epic of reducing dependencies? I do not want to
> >>>> drag
> >>>>>> Tomcat down into my local repo or on my class path in my IDE just
> >>>> because I
> >>>>>> am depending on log4j-appserver's one class for Jetty logging.
> >>>>>>
> >>>>>> Gary
> >>>>>>
> >>>>>> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <
> >> ralph.goers@dslextreme.com
> >>>>>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> That is exactly what log4j-appserver is for. Right now it contains
> >> the
> >>>>>>> hook for Tomcat 8.5. Having that class in a jar that also contains
> >> the
> >>>> hook
> >>>>>>> for Jetty shouldn’t cause any problems.
> >>>>>>>
> >>>>>>> Ralph
> >>>>>>>
> >>>>>>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com>
> >>>> wrote:
> >>>>>>>>
> >>>>>>>> I would like to propose we add a new module called log4j-jetty
> whose
> >>>> sole
> >>>>>>>> purpose is to implement org.eclipse.jetty.util.log.Logger
> >>>>>>>>
> >>>>>>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has
> to
> >>>> go
> >>>>>>>> through Slf4j. I'd rather go directly.
> >>>>>>>>
> >>>>>>>> Thoughts?
> >>>>>>>>
> >>>>>>>> Gary
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>
> >>
> >>
>
>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Ralph Goers <ra...@dslextreme.com>.
Every module equates to another jar. I just don’t see why we need a jar for one class where a jar with 2 (as well as classes for other app servers) will serve equally as well.
Ralph
> On Nov 9, 2017, at 1:16 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> It seems to me that what repo this lives in is an orthogonal concern. We
> already have plenty of repos IMO, I don't want to track another one, but
> hey, that's just me. If log4j-appserver is OK in the main repo, so should
> log4j-jetty.
>
> Gary
>
> On Thu, Nov 9, 2017 at 1:07 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> If you want a specific log4-jetty than we should create a log4j-appserver
>> repo and make log4j-tomcat and log4j-jetty there. Otherwise just put it in
>> log4j-appserver with a provided dependency.
>>
>> Ralph
>>
>>> On Nov 9, 2017, at 11:54 AM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>>
>>> How about we rename log4j-appserver to log4j-tomcat and add log4j-jetty?
>>>
>>> Gary
>>>
>>> On Thu, Nov 9, 2017 at 10:45 AM, Ralph Goers <ralph.goers@dslextreme.com
>>>
>>> wrote:
>>>
>>>> Oops. It should be marked as provided. Almost the same effect though.
>>>>
>>>> Ralph
>>>>
>>>>> On Nov 9, 2017, at 10:44 AM, Ralph Goers <ra...@dslextreme.com>
>>>> wrote:
>>>>>
>>>>> The dependency on Tomcat should have been marked optional. That is my
>>>> mistake.
>>>>>
>>>>> Ralph
>>>>>
>>>>>> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>>>
>>>>>> What about our theme/epic of reducing dependencies? I do not want to
>>>> drag
>>>>>> Tomcat down into my local repo or on my class path in my IDE just
>>>> because I
>>>>>> am depending on log4j-appserver's one class for Jetty logging.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <
>> ralph.goers@dslextreme.com
>>>>>
>>>>>> wrote:
>>>>>>
>>>>>>> That is exactly what log4j-appserver is for. Right now it contains
>> the
>>>>>>> hook for Tomcat 8.5. Having that class in a jar that also contains
>> the
>>>> hook
>>>>>>> for Jetty shouldn’t cause any problems.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>>>>>
>>>>>>>> I would like to propose we add a new module called log4j-jetty whose
>>>> sole
>>>>>>>> purpose is to implement org.eclipse.jetty.util.log.Logger
>>>>>>>>
>>>>>>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has to
>>>> go
>>>>>>>> through Slf4j. I'd rather go directly.
>>>>>>>>
>>>>>>>> Thoughts?
>>>>>>>>
>>>>>>>> Gary
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>
>>
>>
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
It seems to me that what repo this lives in is an orthogonal concern. We
already have plenty of repos IMO, I don't want to track another one, but
hey, that's just me. If log4j-appserver is OK in the main repo, so should
log4j-jetty.
Gary
On Thu, Nov 9, 2017 at 1:07 PM, Ralph Goers <ra...@dslextreme.com>
wrote:
> If you want a specific log4-jetty than we should create a log4j-appserver
> repo and make log4j-tomcat and log4j-jetty there. Otherwise just put it in
> log4j-appserver with a provided dependency.
>
> Ralph
>
> > On Nov 9, 2017, at 11:54 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> >
> > How about we rename log4j-appserver to log4j-tomcat and add log4j-jetty?
> >
> > Gary
> >
> > On Thu, Nov 9, 2017 at 10:45 AM, Ralph Goers <ralph.goers@dslextreme.com
> >
> > wrote:
> >
> >> Oops. It should be marked as provided. Almost the same effect though.
> >>
> >> Ralph
> >>
> >>> On Nov 9, 2017, at 10:44 AM, Ralph Goers <ra...@dslextreme.com>
> >> wrote:
> >>>
> >>> The dependency on Tomcat should have been marked optional. That is my
> >> mistake.
> >>>
> >>> Ralph
> >>>
> >>>> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com>
> >> wrote:
> >>>>
> >>>> What about our theme/epic of reducing dependencies? I do not want to
> >> drag
> >>>> Tomcat down into my local repo or on my class path in my IDE just
> >> because I
> >>>> am depending on log4j-appserver's one class for Jetty logging.
> >>>>
> >>>> Gary
> >>>>
> >>>> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <
> ralph.goers@dslextreme.com
> >>>
> >>>> wrote:
> >>>>
> >>>>> That is exactly what log4j-appserver is for. Right now it contains
> the
> >>>>> hook for Tomcat 8.5. Having that class in a jar that also contains
> the
> >> hook
> >>>>> for Jetty shouldn’t cause any problems.
> >>>>>
> >>>>> Ralph
> >>>>>
> >>>>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com>
> >> wrote:
> >>>>>>
> >>>>>> I would like to propose we add a new module called log4j-jetty whose
> >> sole
> >>>>>> purpose is to implement org.eclipse.jetty.util.log.Logger
> >>>>>>
> >>>>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has to
> >> go
> >>>>>> through Slf4j. I'd rather go directly.
> >>>>>>
> >>>>>> Thoughts?
> >>>>>>
> >>>>>> Gary
> >>>>>
> >>>>>
> >>>>>
> >>>
> >>
> >>
> >>
>
>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Ralph Goers <ra...@dslextreme.com>.
If you want a specific log4-jetty than we should create a log4j-appserver repo and make log4j-tomcat and log4j-jetty there. Otherwise just put it in log4j-appserver with a provided dependency.
Ralph
> On Nov 9, 2017, at 11:54 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> How about we rename log4j-appserver to log4j-tomcat and add log4j-jetty?
>
> Gary
>
> On Thu, Nov 9, 2017 at 10:45 AM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> Oops. It should be marked as provided. Almost the same effect though.
>>
>> Ralph
>>
>>> On Nov 9, 2017, at 10:44 AM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>>
>>> The dependency on Tomcat should have been marked optional. That is my
>> mistake.
>>>
>>> Ralph
>>>
>>>> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>>>
>>>> What about our theme/epic of reducing dependencies? I do not want to
>> drag
>>>> Tomcat down into my local repo or on my class path in my IDE just
>> because I
>>>> am depending on log4j-appserver's one class for Jetty logging.
>>>>
>>>> Gary
>>>>
>>>> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <ralph.goers@dslextreme.com
>>>
>>>> wrote:
>>>>
>>>>> That is exactly what log4j-appserver is for. Right now it contains the
>>>>> hook for Tomcat 8.5. Having that class in a jar that also contains the
>> hook
>>>>> for Jetty shouldn’t cause any problems.
>>>>>
>>>>> Ralph
>>>>>
>>>>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>>>>>
>>>>>> I would like to propose we add a new module called log4j-jetty whose
>> sole
>>>>>> purpose is to implement org.eclipse.jetty.util.log.Logger
>>>>>>
>>>>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has to
>> go
>>>>>> through Slf4j. I'd rather go directly.
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> Gary
>>>>>
>>>>>
>>>>>
>>>
>>
>>
>>
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
How about we rename log4j-appserver to log4j-tomcat and add log4j-jetty?
Gary
On Thu, Nov 9, 2017 at 10:45 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> Oops. It should be marked as provided. Almost the same effect though.
>
> Ralph
>
> > On Nov 9, 2017, at 10:44 AM, Ralph Goers <ra...@dslextreme.com>
> wrote:
> >
> > The dependency on Tomcat should have been marked optional. That is my
> mistake.
> >
> > Ralph
> >
> >> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> >>
> >> What about our theme/epic of reducing dependencies? I do not want to
> drag
> >> Tomcat down into my local repo or on my class path in my IDE just
> because I
> >> am depending on log4j-appserver's one class for Jetty logging.
> >>
> >> Gary
> >>
> >> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <ralph.goers@dslextreme.com
> >
> >> wrote:
> >>
> >>> That is exactly what log4j-appserver is for. Right now it contains the
> >>> hook for Tomcat 8.5. Having that class in a jar that also contains the
> hook
> >>> for Jetty shouldn’t cause any problems.
> >>>
> >>> Ralph
> >>>
> >>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com>
> wrote:
> >>>>
> >>>> I would like to propose we add a new module called log4j-jetty whose
> sole
> >>>> purpose is to implement org.eclipse.jetty.util.log.Logger
> >>>>
> >>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has to
> go
> >>>> through Slf4j. I'd rather go directly.
> >>>>
> >>>> Thoughts?
> >>>>
> >>>> Gary
> >>>
> >>>
> >>>
> >
>
>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Ralph Goers <ra...@dslextreme.com>.
Oops. It should be marked as provided. Almost the same effect though.
Ralph
> On Nov 9, 2017, at 10:44 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>
> The dependency on Tomcat should have been marked optional. That is my mistake.
>
> Ralph
>
>> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> What about our theme/epic of reducing dependencies? I do not want to drag
>> Tomcat down into my local repo or on my class path in my IDE just because I
>> am depending on log4j-appserver's one class for Jetty logging.
>>
>> Gary
>>
>> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>>> That is exactly what log4j-appserver is for. Right now it contains the
>>> hook for Tomcat 8.5. Having that class in a jar that also contains the hook
>>> for Jetty shouldn’t cause any problems.
>>>
>>> Ralph
>>>
>>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> I would like to propose we add a new module called log4j-jetty whose sole
>>>> purpose is to implement org.eclipse.jetty.util.log.Logger
>>>>
>>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has to go
>>>> through Slf4j. I'd rather go directly.
>>>>
>>>> Thoughts?
>>>>
>>>> Gary
>>>
>>>
>>>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Ralph Goers <ra...@dslextreme.com>.
The dependency on Tomcat should have been marked optional. That is my mistake.
Ralph
> On Nov 9, 2017, at 10:34 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> What about our theme/epic of reducing dependencies? I do not want to drag
> Tomcat down into my local repo or on my class path in my IDE just because I
> am depending on log4j-appserver's one class for Jetty logging.
>
> Gary
>
> On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> That is exactly what log4j-appserver is for. Right now it contains the
>> hook for Tomcat 8.5. Having that class in a jar that also contains the hook
>> for Jetty shouldn’t cause any problems.
>>
>> Ralph
>>
>>> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>> I would like to propose we add a new module called log4j-jetty whose sole
>>> purpose is to implement org.eclipse.jetty.util.log.Logger
>>>
>>> There is a way to get Log4j 1 and 2 to work with Jetty but it has to go
>>> through Slf4j. I'd rather go directly.
>>>
>>> Thoughts?
>>>
>>> Gary
>>
>>
>>
Re: [PROPOSAL] New module log4j-jetty
Posted by Gary Gregory <ga...@gmail.com>.
What about our theme/epic of reducing dependencies? I do not want to drag
Tomcat down into my local repo or on my class path in my IDE just because I
am depending on log4j-appserver's one class for Jetty logging.
Gary
On Thu, Nov 9, 2017 at 9:22 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> That is exactly what log4j-appserver is for. Right now it contains the
> hook for Tomcat 8.5. Having that class in a jar that also contains the hook
> for Jetty shouldn’t cause any problems.
>
> Ralph
>
> > On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com> wrote:
> >
> > I would like to propose we add a new module called log4j-jetty whose sole
> > purpose is to implement org.eclipse.jetty.util.log.Logger
> >
> > There is a way to get Log4j 1 and 2 to work with Jetty but it has to go
> > through Slf4j. I'd rather go directly.
> >
> > Thoughts?
> >
> > Gary
>
>
>
Re: [PROPOSAL] New module log4j-jetty
Posted by Ralph Goers <ra...@dslextreme.com>.
That is exactly what log4j-appserver is for. Right now it contains the hook for Tomcat 8.5. Having that class in a jar that also contains the hook for Jetty shouldn’t cause any problems.
Ralph
> On Nov 9, 2017, at 8:55 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> I would like to propose we add a new module called log4j-jetty whose sole
> purpose is to implement org.eclipse.jetty.util.log.Logger
>
> There is a way to get Log4j 1 and 2 to work with Jetty but it has to go
> through Slf4j. I'd rather go directly.
>
> Thoughts?
>
> Gary