You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/25 03:17:57 UTC

[GitHub] [druid] clintropolis opened a new pull request #11031: maybe fix flakiness of leadership integration test

clintropolis opened a new pull request #11031:
URL: https://github.com/apache/druid/pull/11031


   Assertion exceptions weren't being caught inside `ITRetryUtil.retryUntil` callable. This test sometimes fails with something like:
   
   ```
   ERROR] Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 292.819 s <<< FAILURE! - in TestSuite
   [ERROR] testCustomDiscovery(org.apache.druid.tests.leadership.ITHighAvailabilityTest)  Time elapsed: 0.691 s  <<< FAILURE!
   java.lang.AssertionError: expected [200 OK] but found [403 Forbidden]
   	at org.apache.druid.tests.leadership.ITHighAvailabilityTest.testSelfDiscovery(ITHighAvailabilityTest.java:187)
   	at org.apache.druid.tests.leadership.ITHighAvailabilityTest.lambda$testCustomDiscovery$1(ITHighAvailabilityTest.java:160)
   	at org.apache.druid.tests.leadership.ITHighAvailabilityTest.testCustomDiscovery(ITHighAvailabilityTest.java:156)
   [ERROR] testDiscoveryAndSelfDiscovery(org.apache.druid.tests.leadership.ITHighAvailabilityTest)  Time elapsed: 0.699 s  <<< FAILURE!
   java.lang.AssertionError: expected [200 OK] but found [403 Forbidden]
   	at org.apache.druid.tests.leadership.ITHighAvailabilityTest.testSelfDiscovery(ITHighAvailabilityTest.java:187)
   	at org.apache.druid.tests.leadership.ITHighAvailabilityTest.lambda$testDiscoveryAndSelfDiscovery$0(ITHighAvailabilityTest.java:142)
   	at org.apache.druid.tests.leadership.ITHighAvailabilityTest.testDiscoveryAndSelfDiscovery(ITHighAvailabilityTest.java:127)
   [ERROR] testLeadershipChanges(org.apache.druid.tests.leadership.ITHighAvailabilityTest)  Time elapsed: 144.526 s
   ```
   
    I'm not sure why the status code on the self discovered endpoint is returning 403 sometimes, maybe it is some sort of race condition with the service starting up, but this should at least let it retry correctly, which hopefully will make it fail a bit less often.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis merged pull request #11031: maybe fix flakiness of leadership integration test

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11031:
URL: https://github.com/apache/druid/pull/11031


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org