[jira] [Commented] (HTTPASYNC-48) InternalHttpAsyncClientThread.reactorThread should be created via ThreadFactory

["Dmitry Potapov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPASYNC-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706138#comment-13706138 ] 

Dmitry Potapov commented on HTTPASYNC-48:
-----------------------------------------

I haven't introduced any changes concerning reactorThread construction to AbstractHttpClient because it is marked as deprecated. Also, no changes were introduced to MinimalHttpAsyncClient, because it is not intended to be configurable.
                
> InternalHttpAsyncClientThread.reactorThread should be created via ThreadFactory
> -------------------------------------------------------------------------------
>
>                 Key: HTTPASYNC-48
>                 URL: https://issues.apache.org/jira/browse/HTTPASYNC-48
>             Project: HttpComponents HttpAsyncClient
>          Issue Type: Improvement
>    Affects Versions: 4.0-beta4, Future
>            Reporter: Dmitry Potapov
>            Priority: Trivial
>         Attachments: httpasyncclient.patch
>
>
> InternalHttpAsyncClientThread.reactorThread is created via implicit call to "new Thread()" which doesn't allow to configure reactor thread priority and name, which may lead to some inconvenience during debug or performance profiling.
> My proposal is to pass java.util.concurrent.ThreadFactory to InternalHttpAsyncClientThread.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org