You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by pa...@apache.org on 2018/10/08 14:04:21 UTC
svn commit: r1843146 - in /turbine/fulcrum/trunk/yaafi/src:
java/org/apache/fulcrum/yaafi/cli/Main.java
java/org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java
test/org/apache/fulcrum/yaafi/TestComponentTest.java
Author: painter
Date: Mon Oct 8 14:04:21 2018
New Revision: 1843146
URL: http://svn.apache.org/viewvc?rev=1843146&view=rev
Log:
Cleaning up from findbugs
Modified:
turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/cli/Main.java
turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java
turbine/fulcrum/trunk/yaafi/src/test/org/apache/fulcrum/yaafi/TestComponentTest.java
Modified: turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/cli/Main.java
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/cli/Main.java?rev=1843146&r1=1843145&r2=1843146&view=diff
==============================================================================
--- turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/cli/Main.java (original)
+++ turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/cli/Main.java Mon Oct 8 14:04:21 2018
@@ -106,7 +106,7 @@ public class Main implements Runnable, D
this.applicationHome = ".";
this.tempHome = System.getProperty("java.io.tmpdir",".");
this.applicationName = "main";
- this.args = ( args != null ? args : new String[0] );
+ this.args = ( this.args != null ? this.args : new String[0] );
this.isBlocking = false;
this.hasShutdownHook = true;
this.isInitialized = false;
Modified: turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java?rev=1843146&r1=1843145&r2=1843146&view=diff
==============================================================================
--- turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java (original)
+++ turbine/fulcrum/trunk/yaafi/src/java/org/apache/fulcrum/yaafi/service/baseservice/BaseServiceImpl.java Mon Oct 8 14:04:21 2018
@@ -232,7 +232,10 @@ public abstract class BaseServiceImpl
*/
protected void release(Object object)
{
- this.release(object);
+ if ( object != null )
+ {
+ object = null;
+ }
}
/**
Modified: turbine/fulcrum/trunk/yaafi/src/test/org/apache/fulcrum/yaafi/TestComponentTest.java
URL: http://svn.apache.org/viewvc/turbine/fulcrum/trunk/yaafi/src/test/org/apache/fulcrum/yaafi/TestComponentTest.java?rev=1843146&r1=1843145&r2=1843146&view=diff
==============================================================================
--- turbine/fulcrum/trunk/yaafi/src/test/org/apache/fulcrum/yaafi/TestComponentTest.java (original)
+++ turbine/fulcrum/trunk/yaafi/src/test/org/apache/fulcrum/yaafi/TestComponentTest.java Mon Oct 8 14:04:21 2018
@@ -57,8 +57,9 @@ public class TestComponentTest extends B
assertNotNull( testComponent.getUrnAvalonName() );
assertNotNull( testComponent.getUrnAvalonPartition() );
- Object [] temp = new Object[10];
- System.out.println(temp.toString());
+ // Not sure what this code was for, but causing a findbugs error
+ //Object [] temp = new Object[10];
+ //System.out.println(temp.toString());
try
{