You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "swaminathanmanish (via GitHub)" <gi...@apache.org> on 2023/02/27 16:57:16 UTC
[GitHub] [pinot] swaminathanmanish opened a new pull request, #10324: Adding table name to create unique Kafka consumer client Ids
swaminathanmanish opened a new pull request, #10324:
URL: https://github.com/apache/pinot/pull/10324
This PR is to fix the issue in #10014 by creating unique Kafka consumer client Ids. Adding table name makes the clientId unique.
**Problem**: Duplicate Ids renders MBeans useless and clutters the log with warnings. Examples of warnings are provided in #10014.
**Test**: Verified new metrics are visible via jconsole MBeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jugomezv commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "jugomezv (via GitHub)" <gi...@apache.org>.
jugomezv commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1445273911
I pulled the change and look at the main metrics we use in our dashboard related with consumption and as expected they don't change them, I will ping the SREs Monday to make sure I did not miss anything.
One small suggestion would be to remove _metricKeyName and replace its uses with _clientId as they will be exactly the same after this change, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1447172186
Thanks @jugomezv !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] snleee commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442608074
@mcvsubbu I think that this behavior will not change often once the change is checked in. We made a similar id change about 3 yrs ago https://github.com/apache/pinot/pull/4955
If this change will break the dashboard for LNKD, then yes, we should definitely add a way to override the behavior on client id creation. If the impact from the name change is not critical, I would prefer to less configuration points for Pinot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jugomezv commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "jugomezv (via GitHub)" <gi...@apache.org>.
jugomezv commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442642760
> @mcvsubbu @sajjad-moradi @jugomezv Can you double check on this change given that this may start to emit metrics using different name?
@snleee thanks for bringing this up, let me pull the change and test locally but seems this may break things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] navina commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "navina (via GitHub)" <gi...@apache.org>.
navina commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442676787
@snleee / @mcvsubbu I don't think Linkedin is using any of the underlying metrics from the kafka consumer in the dashboards, which is what gets affected due to this change. And I agree with @snleee that we shouldn't introduce another knob/api for this.
More to the point, I don't think linkedin should be using those metrics in the current state at least. They are bound to be inaccurate unless there is an external mechanism in linkedin that can ensure that no topic is consumed by more than 1 pinot table. Moreover, all our spis accept clientId in their interfaces and there is no way currently to customize it.
Anyway, let's wait for @jugomezv to confirm. Tks all for jumping in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1446690332
> _metricKeyName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] snleee commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442585515
@mcvsubbu @sajjad-moradi @jugomezv Can you double check on this change given that this may start to emit metrics using different name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442519884
@navina , @snleee - Could you please review ? Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1447054771
# [Codecov](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10324](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23c84e0) into [master](https://codecov.io/gh/apache/pinot/commit/1fce07ed77ff31af6d3b85a6b03a4b76632ed133?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fce07e) will **increase** coverage by `1.42%`.
> The diff coverage is `87.50%`.
```diff
@@ Coverage Diff @@
## master #10324 +/- ##
============================================
+ Coverage 68.82% 70.25% +1.42%
- Complexity 5851 5901 +50
============================================
Files 2027 2027
Lines 109891 109954 +63
Branches 16685 16711 +26
============================================
+ Hits 75637 77244 +1607
+ Misses 28897 27283 -1614
- Partials 5357 5427 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.40% <62.50%> (?)` | |
| integration2 | `24.48% <70.83%> (-0.02%)` | :arrow_down: |
| unittests1 | `67.68% <62.50%> (+0.04%)` | :arrow_up: |
| unittests2 | `13.76% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/spi/stream/PartitionGroupMetadataFetcher.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvc3RyZWFtL1BhcnRpdGlvbkdyb3VwTWV0YWRhdGFGZXRjaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `72.42% <95.45%> (+2.16%)` | :arrow_up: |
| [...pinot/spi/exception/EarlyTerminationException.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZXhjZXB0aW9uL0Vhcmx5VGVybWluYXRpb25FeGNlcHRpb24uamF2YQ==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...or/transform/function/IsNullTransformFunction.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vSXNOdWxsVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `79.31% <0.00%> (-6.90%)` | :arrow_down: |
| [...transform/function/IsNotNullTransformFunction.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vSXNOb3ROdWxsVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `65.51% <0.00%> (-6.90%)` | :arrow_down: |
| [...n/java/org/apache/pinot/common/utils/URIUtils.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvVVJJVXRpbHMuamF2YQ==) | `71.87% <0.00%> (-6.25%)` | :arrow_down: |
| [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3BlcmlvZGljdGFzay9Db250cm9sbGVyUGVyaW9kaWNUYXNrLmphdmE=) | `66.07% <0.00%> (-5.36%)` | :arrow_down: |
| [.../main/java/org/apache/pinot/spi/trace/Tracing.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvVHJhY2luZy5qYXZh) | `69.62% <0.00%> (-2.54%)` | :arrow_down: |
| [...re/accounting/PerQueryCPUMemAccountantFactory.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9hY2NvdW50aW5nL1BlclF1ZXJ5Q1BVTWVtQWNjb3VudGFudEZhY3RvcnkuamF2YQ==) | `75.81% <0.00%> (-1.91%)` | :arrow_down: |
| [...t/creator/impl/SegmentIndexCreationDriverImpl.java](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50SW5kZXhDcmVhdGlvbkRyaXZlckltcGwuamF2YQ==) | `80.10% <0.00%> (-1.62%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/pinot/pull/10324?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish closed pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish closed pull request #10324: Adding table name to create unique Kafka consumer client Ids
URL: https://github.com/apache/pinot/pull/10324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish commented on code in PR #10324:
URL: https://github.com/apache/pinot/pull/10324#discussion_r1119033779
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,7 +63,8 @@ public Exception getException() {
@Override
public Boolean call()
throws Exception {
- String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-" + _topicName;
+ String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"
Review Comment:
Wouldn't table name itself give that uniqueness ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mcvsubbu commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "mcvsubbu (via GitHub)" <gi...@apache.org>.
mcvsubbu commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1442588942
Does it make sense to introduce an API to the stream to generate a client ID (given some inputs)? That way, these things can be tailored on a per installation basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jugomezv commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "jugomezv (via GitHub)" <gi...@apache.org>.
jugomezv commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1447163346
Thanks for the change, yes looks good, I made sure with our SREs that the metrics we use related to consumption do not change in name. Lets merge! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] snleee merged pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "snleee (via GitHub)" <gi...@apache.org>.
snleee merged PR #10324:
URL: https://github.com/apache/pinot/pull/10324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish commented on pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish commented on PR #10324:
URL: https://github.com/apache/pinot/pull/10324#issuecomment-1446706132
@jugomezv - Thanks for verifying that there's no side effect. I'll clean up _metricKeyName and update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] navina commented on a diff in pull request #10324: Adding table name to create unique Kafka consumer client Ids
Posted by "navina (via GitHub)" <gi...@apache.org>.
navina commented on code in PR #10324:
URL: https://github.com/apache/pinot/pull/10324#discussion_r1118945939
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,7 +63,8 @@ public Exception getException() {
@Override
public Boolean call()
throws Exception {
- String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-" + _topicName;
+ String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"
Review Comment:
I wonder if we should also add a timestamp here since this is part of a periodic task. Shouldn't matter much as the usage here is limited to metadata lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org