You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/10 07:45:32 UTC
[GitHub] [lucene] jpountz opened a new issue, #11914: Remove QueryTimeout#isTimeoutEnabled?
jpountz opened a new issue, #11914:
URL: https://github.com/apache/lucene/issues/11914
### Description
I don't understand well why `QueryTimeout` has a `isTimeoutEnabled` method. If the timeout is not enabled, why configure a timeout at all?
### Version and environment details
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] shubhamvishu commented on issue #11914: Remove QueryTimeout#isTimeoutEnabled?
Posted by GitBox <gi...@apache.org>.
shubhamvishu commented on issue #11914:
URL: https://github.com/apache/lucene/issues/11914#issuecomment-1312012201
I can work on it. But to understand better, I see this being used in `ExitableDirectoryReader` where conditionally the `ExitableXYZ` wrapper is returned for `XYZ` class. Could this be to conditionally turn off the timeout so timeout could be used only if required else it could be turned off or something ?. Just my initial thought from the issue description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on issue #11914: Remove QueryTimeout#isTimeoutEnabled?
Posted by GitBox <gi...@apache.org>.
jpountz commented on issue #11914:
URL: https://github.com/apache/lucene/issues/11914#issuecomment-1313907213
@shubhamvishu Yes, my thinking was to push the responsibility to the caller and only wrap with an `ExitableDirectoryReader` if there is actually a timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz closed issue #11914: Remove QueryTimeout#isTimeoutEnabled?
Posted by GitBox <gi...@apache.org>.
jpountz closed issue #11914: Remove QueryTimeout#isTimeoutEnabled?
URL: https://github.com/apache/lucene/issues/11914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org