[GitHub] dspavlov commented on a change in pull request #94: Visa History page fix

[GitBox <gi...@apache.org>]

dspavlov commented on a change in pull request #94: Visa History page fix
URL: https://github.com/apache/ignite-teamcity-bot/pull/94#discussion_r239898896
 
 

 ##########
 File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
 ##########
 @@ -107,16 +108,16 @@ public BuildsInfo(String srvId, ICredentialsProv prov, String ticket, String bra
      * @return One of {@link #FINISHED_STATUS}, {@link #CANCELLED_STATUS} or
      * {@link #RUNNING_STATUS} statuses.
      */
-    public String getStatus(IAnalyticsEnabledTeamcity teamcity) {
+    public String getStatus(ITeamcityIgnited teamcity) {
         boolean isFinished = true;
 
         for (Integer id : builds) {
-            Build build = teamcity.getBuild(id);
+            FatBuildCompacted build = teamcity.getFatBuild(id);
 
-            if (build.isUnknown())
+            if (build.isFakeStub() || build.isCancelled(teamcity.compactor()))
 
 Review comment:
   we can inject compactor where needed. For cases it is used not in injector created classes it is better to use it as a parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services