You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2016/03/02 16:35:00 UTC
svn commit: r1733313 - in /myfaces/tobago/branches/tobago-3.0.x:
tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/
tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/
Author: lofwyr
Date: Wed Mar 2 15:34:59 2016
New Revision: 1733313
URL: http://svn.apache.org/viewvc?rev=1733313&view=rev
Log:
writeAttributes() for Integer now ignores null values
Modified:
myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ButtonRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/CommandRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/FileRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/InRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LinkRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectBooleanCheckboxRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyCheckboxRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyListboxRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyShuttleRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneChoiceRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneListboxRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneRadioRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java
myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TextareaRenderer.java
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriter.java Wed Mar 2 15:34:59 2016
@@ -124,10 +124,12 @@ public abstract class TobagoResponseWrit
}
/**
- * Writes a integer attribute. The value will not escaped.
+ * Writes a {@link Integer} attribute, if the value is not {@code null}. The value will not be escaped.
*/
- public void writeAttribute(final MarkupLanguageAttributes name, final int number) throws IOException {
- writeAttribute(name, Integer.toString(number), false);
+ public void writeAttribute(final MarkupLanguageAttributes name, final Integer number) throws IOException {
+ if (number != null) {
+ writeAttribute(name, Integer.toString(number), false);
+ }
}
/**
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ButtonRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ButtonRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ButtonRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/ButtonRenderer.java Wed Mar 2 15:34:59 2016
@@ -87,10 +87,7 @@ public class ButtonRenderer extends Comm
}
if (button instanceof UIButton) {
- final Integer tabIndex = ((UIButton) button).getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, ((UIButton) button).getTabIndex());
}
String commands = null;
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/CommandRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/CommandRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/CommandRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/CommandRenderer.java Wed Mar 2 15:34:59 2016
@@ -82,10 +82,8 @@ public class CommandRenderer extends Com
AccessKeyLogger.addAccessKey(facesContext, label.getAccessKey(), clientId);
}
- final Integer tabIndex = link instanceof AbstractUILink ? ((AbstractUILink) link).getTabIndex() : null;
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX,
+ link instanceof AbstractUILink ? ((AbstractUILink) link).getTabIndex() : null);
}
HtmlRendererUtils.writeDataAttributes(facesContext, writer, link);
writer.writeStyleAttribute(link.getStyle());
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/FileRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/FileRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/FileRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/FileRenderer.java Wed Mar 2 15:34:59 2016
@@ -142,10 +142,7 @@ TODO: Using Servlet 3.0 file upload...
writer.writeAttribute(HtmlAttributes.READONLY, file.isReadonly());
writer.writeAttribute(HtmlAttributes.REQUIRED, file.isRequired());
writer.writeAttribute(HtmlAttributes.SIZE, "1024", false);
- final Integer tabIndex = file.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, file.getTabIndex());
final String title = HtmlRendererUtils.getTitleFromTipAndMessages(facesContext, file);
if (title != null) {
writer.writeAttribute(HtmlAttributes.TITLE, title, true);
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/InRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/InRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/InRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/InRenderer.java Wed Mar 2 15:34:59 2016
@@ -102,10 +102,7 @@ public class InRenderer extends InputRen
}
writer.writeAttribute(HtmlAttributes.READONLY, readonly);
writer.writeAttribute(HtmlAttributes.DISABLED, disabled);
- final Integer tabIndex = input.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, input.getTabIndex());
writer.writeStyleAttribute(input.getStyle());
final String placeholder = input.getPlaceholder();
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LinkRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LinkRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LinkRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/LinkRenderer.java Wed Mar 2 15:34:59 2016
@@ -63,10 +63,7 @@ public class LinkRenderer extends Comman
AccessKeyLogger.addAccessKey(facesContext, label.getAccessKey(), clientId);
}
- final Integer tabIndex = link.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, link.getTabIndex());
}
HtmlRendererUtils.writeDataAttributes(facesContext, writer, link);
writer.writeStyleAttribute(link.getStyle());
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectBooleanCheckboxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectBooleanCheckboxRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectBooleanCheckboxRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectBooleanCheckboxRenderer.java Wed Mar 2 15:34:59 2016
@@ -111,10 +111,7 @@ public class SelectBooleanCheckboxRender
HtmlRendererUtils.renderFocus(clientId, select.isFocus(), ComponentUtils.isError(select), facesContext, writer);
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
HtmlRendererUtils.renderCommandFacet(select, facesContext, writer);
writer.endElement(HtmlElements.INPUT);
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyCheckboxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyCheckboxRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyCheckboxRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyCheckboxRenderer.java Wed Mar 2 15:34:59 2016
@@ -92,10 +92,7 @@ public class SelectManyCheckboxRenderer
HtmlRendererUtils.renderFocus(id, select.isFocus(), ComponentUtils.isError(select), facesContext, writer);
first = false;
}
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
HtmlRendererUtils.renderCommandFacet(select, itemId, facesContext, writer);
writer.endElement(HtmlElements.INPUT);
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyListboxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyListboxRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyListboxRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyListboxRenderer.java Wed Mar 2 15:34:59 2016
@@ -62,10 +62,7 @@ public class SelectManyListboxRenderer e
writer.writeAttribute(HtmlAttributes.READONLY, readonly);
writer.writeAttribute(HtmlAttributes.REQUIRED, select.isRequired());
HtmlRendererUtils.renderFocus(id, select.isFocus(), ComponentUtils.isError(select), facesContext, writer);
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
writer.writeStyleAttribute(select.getStyle());
writer.writeClassAttribute(Classes.create(select), BootstrapClass.FORM_CONTROL, select.getCustomClass());
writer.writeAttribute(HtmlAttributes.MULTIPLE, true);
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyShuttleRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyShuttleRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyShuttleRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectManyShuttleRenderer.java Wed Mar 2 15:34:59 2016
@@ -74,10 +74,7 @@ public class SelectManyShuttleRenderer e
writer.writeAttribute(HtmlAttributes.DISABLED, disabled);
// TODO tabIndex
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
writer.writeClassAttribute(Classes.create(select, "unselected"), BootstrapClass.FORM_CONTROL);
@@ -113,9 +110,7 @@ public class SelectManyShuttleRenderer e
writer.writeIdAttribute(selectedClientId);
writer.writeAttribute(HtmlAttributes.DISABLED, disabled);
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
writer.writeClassAttribute(Classes.create(select, "selected"), BootstrapClass.FORM_CONTROL);
writer.writeAttribute(HtmlAttributes.MULTIPLE, true);
writer.writeAttribute(HtmlAttributes.SIZE, rows);
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneChoiceRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneChoiceRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneChoiceRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneChoiceRenderer.java Wed Mar 2 15:34:59 2016
@@ -54,10 +54,7 @@ public class SelectOneChoiceRenderer ext
writer.writeIdAttribute(id);
HtmlRendererUtils.writeDataAttributes(facesContext, writer, select);
writer.writeAttribute(HtmlAttributes.DISABLED, disabled);
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
writer.writeStyleAttribute(select.getStyle());
writer.writeClassAttribute(Classes.create(select), BootstrapClass.FORM_CONTROL, select.getCustomClass());
if (title != null) {
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneListboxRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneListboxRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneListboxRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneListboxRenderer.java Wed Mar 2 15:34:59 2016
@@ -59,16 +59,11 @@ public class SelectOneListboxRenderer ex
writer.writeAttribute(HtmlAttributes.REQUIRED, select.isRequired());
HtmlRendererUtils.renderFocus(id, select.isFocus(), ComponentUtils.isError(select), facesContext, writer);
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
writer.writeStyleAttribute(select.getStyle());
writer.writeClassAttribute(Classes.create(select), BootstrapClass.FORM_CONTROL, select.getCustomClass());
final String title = HtmlRendererUtils.getTitleFromTipAndMessages(facesContext, select);
- if (title != null) {
- writer.writeAttribute(HtmlAttributes.TITLE, title, true);
- }
+ writer.writeAttribute(HtmlAttributes.TITLE, title, true);
writer.writeAttribute(HtmlAttributes.SIZE, rows != null ? rows : items.size());
HtmlRendererUtils.renderCommandFacet(select, facesContext, writer);
HtmlRendererUtils.renderSelectItems(select, items, select.getValue(), (String) select.getSubmittedValue(),
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneRadioRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneRadioRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneRadioRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SelectOneRadioRenderer.java Wed Mar 2 15:34:59 2016
@@ -93,10 +93,7 @@ public class SelectOneRadioRenderer exte
HtmlRendererUtils.renderFocus(id, select.isFocus(), ComponentUtils.isError(select), facesContext, writer);
first = false;
}
- final Integer tabIndex = select.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, select.getTabIndex());
HtmlRendererUtils.renderCommandFacet(select, itemId, facesContext, writer);
writer.endElement(HtmlElements.INPUT);
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java Wed Mar 2 15:34:59 2016
@@ -643,9 +643,7 @@ public class SheetRenderer extends Rende
private void writeCol(final TobagoResponseWriter writer, final Integer columnWidth) throws IOException {
writer.startElement(HtmlElements.COL);
- if (columnWidth != null) {
- writer.writeAttribute(HtmlAttributes.WIDTH, columnWidth);
- }
+ writer.writeAttribute(HtmlAttributes.WIDTH, columnWidth);
writer.endElement(HtmlElements.COL);
}
Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TextareaRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TextareaRenderer.java?rev=1733313&r1=1733312&r2=1733313&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TextareaRenderer.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/TextareaRenderer.java Wed Mar 2 15:34:59 2016
@@ -54,25 +54,18 @@ public class TextareaRenderer extends In
final String title = HtmlRendererUtils.getTitleFromTipAndMessages(facesContext, component);
final String clientId = input.getClientId(facesContext);
final TobagoResponseWriter writer = HtmlRendererUtils.getTobagoResponseWriter(facesContext);
+ final Integer rows = input.getRows();
writer.startElement(HtmlElements.TEXTAREA);
writer.writeNameAttribute(clientId);
writer.writeIdAttribute(clientId);
HtmlRendererUtils.writeDataAttributes(facesContext, writer, input);
- final Integer rows = input.getRows();
- if (rows != null) {
- writer.writeAttribute(HtmlAttributes.ROWS, rows);
- }
- if (title != null) {
- writer.writeAttribute(HtmlAttributes.TITLE, title, true);
- }
+ writer.writeAttribute(HtmlAttributes.ROWS, rows);
+ writer.writeAttribute(HtmlAttributes.TITLE, title, true);
writer.writeAttribute(HtmlAttributes.READONLY, input.isReadonly());
writer.writeAttribute(HtmlAttributes.DISABLED, input.isDisabled());
writer.writeAttribute(HtmlAttributes.REQUIRED, input.isRequired());
- final Integer tabIndex = input.getTabIndex();
- if (tabIndex != null) {
- writer.writeAttribute(HtmlAttributes.TABINDEX, tabIndex);
- }
+ writer.writeAttribute(HtmlAttributes.TABINDEX, input.getTabIndex());
writer.writeClassAttribute(Classes.create(input), BootstrapClass.FORM_CONTROL, input.getCustomClass());
writer.writeStyleAttribute(input.getStyle());