[GitHub] [beam] lostluck commented on a change in pull request #15191: [BEAM-12639] Allow for zero splits in SplitAndSizeRestriction

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #15191:
URL: https://github.com/apache/beam/pull/15191#discussion_r680412791



##########
File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers_test.go
##########
@@ -382,3 +382,50 @@ func (fn *VetKvSdf) ProcessElement(rt *VetRTracker, i, j int, emit func(*VetRest
 	rest.ProcessElm = true
 	emit(rest)
 }
+
+// VetEmptyInitialSplitSdf runs an SDF in order to test that these methods get called properly,
+// each method will flip the corresponding flag in the passed in VetRestriction,
+// overwrite the restriction's Key and Val with the last seen input elements,
+// and retain the other fields in the VetRestriction.
+type VetEmptyInitialSplitSdf struct {

Review comment:
       That sounds about right. The compiler does hoist embeded type methods to the parent type, but the reflect libraries don't automatically hoist methods on embedded types. We'd need to add it to the analysis to get it working. Not hard, just hasn't been required to add.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org