You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RoyLee1224 (via GitHub)" <gi...@apache.org> on 2025/08/11 21:07:50 UTC
[PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
RoyLee1224 opened a new pull request, #54370:
URL: https://github.com/apache/airflow/pull/54370
Fixes browser console warnings `The specified value 'Invalid Date' does not conform to the required format` by adding proper date validation before formatting.
- Return empty string for invalid dates instead of formatted **"Invalid Date"**
- Affects all components using DateTimeInput:
- DAG triggers
- Backfill forms
- Incoming filters #53040
| Before | After |
| :---: | :---: |
| <img src="https://github.com/user-attachments/assets/bf5bb11e-b975-4a50-8cfe-0790cfb92f0d" width="350"> | <img src="https://github.com/user-attachments/assets/87e886d6-f650-4350-9394-6fec0f0f04ce" width="350"> |
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on PR #54370:
URL: https://github.com/apache/airflow/pull/54370#issuecomment-3201352217
@bbovenzi Sure, that looks like a better solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 closed pull request #54370: fix(ui): handle invalid dates for DateTimeInput
URL: https://github.com/apache/airflow/pull/54370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on PR #54370:
URL: https://github.com/apache/airflow/pull/54370#issuecomment-3190446317
My apologies for the notification spam. I made a mistake while resolving conflicts, which added many of you as reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #54370:
URL: https://github.com/apache/airflow/pull/54370#discussion_r2270342467
##########
airflow-core/src/airflow/ui/src/components/DateTimeInput.tsx:
##########
@@ -32,8 +32,11 @@ type Props = {
export const DateTimeInput = forwardRef<HTMLInputElement, Props>(({ onChange, value, ...rest }, ref) => {
const { selectedTimezone } = useTimezone();
- // Make the value timezone-aware
- const date = dayjs(value).tz(selectedTimezone).format("YYYY-MM-DDTHH:mm:ss.SSS");
+ // Make the value timezone-aware, handle invalid dates
+ const date =
+ value !== "" && dayjs(value).isValid()
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #54370:
URL: https://github.com/apache/airflow/pull/54370#issuecomment-3187965427
Static check failure. Just need to run `pnpm format` locally I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "RoyLee1224 (via GitHub)" <gi...@apache.org>.
RoyLee1224 commented on code in PR #54370:
URL: https://github.com/apache/airflow/pull/54370#discussion_r2271545493
##########
airflow-core/src/airflow/ui/src/components/DateTimeInput.tsx:
##########
@@ -32,8 +32,11 @@ type Props = {
export const DateTimeInput = forwardRef<HTMLInputElement, Props>(({ onChange, value, ...rest }, ref) => {
const { selectedTimezone } = useTimezone();
- // Make the value timezone-aware
- const date = dayjs(value).tz(selectedTimezone).format("YYYY-MM-DDTHH:mm:ss.SSS");
+ // Make the value timezone-aware, handle invalid dates
+ const date =
+ value !== "" && dayjs(value).isValid()
Review Comment:
SURE! Makes perfect sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54370:
URL: https://github.com/apache/airflow/pull/54370#discussion_r2268603129
##########
airflow-core/src/airflow/ui/src/components/DateTimeInput.tsx:
##########
@@ -32,8 +32,11 @@ type Props = {
export const DateTimeInput = forwardRef<HTMLInputElement, Props>(({ onChange, value, ...rest }, ref) => {
const { selectedTimezone } = useTimezone();
- // Make the value timezone-aware
- const date = dayjs(value).tz(selectedTimezone).format("YYYY-MM-DDTHH:mm:ss.SSS");
+ // Make the value timezone-aware, handle invalid dates
+ const date =
+ value !== "" && dayjs(value).isValid()
Review Comment:
`isValid()` would handle `value == =""` case. Leaving one condition is enough and clearer IMO.
```suggestion
dayjs(value).isValid()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54370:
URL: https://github.com/apache/airflow/pull/54370#discussion_r2268603129
##########
airflow-core/src/airflow/ui/src/components/DateTimeInput.tsx:
##########
@@ -32,8 +32,11 @@ type Props = {
export const DateTimeInput = forwardRef<HTMLInputElement, Props>(({ onChange, value, ...rest }, ref) => {
const { selectedTimezone } = useTimezone();
- // Make the value timezone-aware
- const date = dayjs(value).tz(selectedTimezone).format("YYYY-MM-DDTHH:mm:ss.SSS");
+ // Make the value timezone-aware, handle invalid dates
+ const date =
+ value !== "" && dayjs(value).isValid()
Review Comment:
`isValid()` would handle `value === ""` case. Leaving one condition is enough and clearer IMO.
```suggestion
dayjs(value).isValid()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): handle invalid dates for DateTimeInput [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #54370:
URL: https://github.com/apache/airflow/pull/54370#issuecomment-3197865689
Actually, I wonder if we should just make sure #54593 has an isValid check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org