You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2025/11/06 16:25:50 UTC
[PR] [chore](cast) simplify CastExpr's code [doris]
morrySnow opened a new pull request, #57775:
URL: https://github.com/apache/doris/pull/57775
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [x] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3498608964
# FE UT Coverage Report
Increment line coverage ` 45.45% (5/11)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57775_49810b1ed6541a9be119c4fb43cdec6be61e7044/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57775_49810b1ed6541a9be119c4fb43cdec6be61e7044/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3501168042
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3500634094
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3500978868
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.50% (24272/33946) |
| Line Coverage | 58.01% (252604/435427) |
| Region Coverage | 53.39% (210754/394708) |
| Branch Coverage | 54.65% (89843/164407) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3501568871
# BE Regression && UT Coverage Report
Increment line coverage `0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.50% (24271/33946) |
| Line Coverage | 57.99% (252524/435427) |
| Region Coverage | 53.37% (210648/394708) |
| Branch Coverage | 54.64% (89836/164407) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3501607630
# FE Regression Coverage Report
Increment line coverage ` 44.44% (4/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #57775:
URL: https://github.com/apache/doris/pull/57775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3500705574
<details>
<summary>TPC-DS: <b>Total hot run time: 187959 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 517d0a3ad902a8d4d45eb9f3a22803d4eab84af5, data reload: false
query1 1045 399 396 396
query2 6211 1688 1718 1688
query3 6191 220 230 220
query4 26450 23731 23127 23127
query5 4343 604 458 458
query6 328 233 239 233
query7 4340 497 311 311
query8 332 262 261 261
query9 7103 2597 2573 2573
query10 362 347 300 300
query11 15434 15016 14826 14826
query12 183 121 113 113
query13 2009 583 438 438
query14 11067 9272 9211 9211
query15 213 196 177 177
query16 7450 706 523 523
query17 1200 748 612 612
query18 2004 408 321 321
query19 204 196 167 167
query20 126 123 122 122
query21 213 135 114 114
query22 4126 4184 4087 4087
query23 33844 32944 32906 32906
query24 8019 2394 2406 2394
query25 572 527 446 446
query26 1236 274 156 156
query27 2756 502 355 355
query28 4396 2213 2167 2167
query29 752 630 489 489
query30 302 221 199 199
query31 915 835 730 730
query32 87 75 82 75
query33 586 394 361 361
query34 804 864 532 532
query35 826 830 792 792
query36 955 976 916 916
query37 131 118 90 90
query38 3499 3512 3463 3463
query39 1480 1441 1417 1417
query40 236 131 130 130
query41 69 66 67 66
query42 126 120 120 120
query43 493 507 472 472
query44 1238 757 738 738
query45 208 179 187 179
query46 900 1001 645 645
query47 1788 1805 1720 1720
query48 419 431 349 349
query49 808 548 450 450
query50 648 684 416 416
query51 3919 3930 3900 3900
query52 116 115 106 106
query53 241 268 199 199
query54 324 321 294 294
query55 90 93 86 86
query56 379 325 324 324
query57 1206 1169 1130 1130
query58 295 288 290 288
query59 2620 2723 2543 2543
query60 375 373 342 342
query61 190 200 199 199
query62 799 732 676 676
query63 236 203 200 200
query64 4447 1174 829 829
query65 4059 3994 3934 3934
query66 1137 445 334 334
query67 15593 15342 15106 15106
query68 8930 944 616 616
query69 482 321 290 290
query70 1316 1304 1304 1304
query71 477 335 313 313
query72 5843 4980 4947 4947
query73 687 589 362 362
query74 8896 9104 8669 8669
query75 3985 3313 2839 2839
query76 3801 1163 746 746
query77 829 409 320 320
query78 9572 9644 8870 8870
query79 2743 833 591 591
query80 725 555 517 517
query81 522 270 228 228
query82 475 156 136 136
query83 287 263 257 257
query84 251 110 88 88
query85 926 487 443 443
query86 389 314 319 314
query87 3727 3681 3570 3570
query88 3780 2306 2287 2287
query89 411 335 297 297
query90 1941 220 232 220
query91 180 175 149 149
query92 82 69 73 69
query93 2235 977 641 641
query94 705 453 348 348
query95 419 328 352 328
query96 492 571 291 291
query97 2921 2989 2866 2866
query98 241 214 221 214
query99 1345 1394 1288 1288
Total cold run time: 274668 ms
Total hot run time: 187959 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3500812162
# BE UT Coverage Report
Increment line coverage `0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.78% (18225/34532) |
| Line Coverage | 38.13% (165754/434709) |
| Region Coverage | 33.14% (128994/389187) |
| Branch Coverage | 33.87% (55320/163324) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3498194290
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3501008655
# FE Regression Coverage Report
Increment line coverage ` 44.44% (4/9)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57775_517d0a3ad902a8d4d45eb9f3a22803d4eab84af5_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3498194190
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3500717932
<details>
<summary>ClickBench: <b>Total hot run time: 27.43 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 517d0a3ad902a8d4d45eb9f3a22803d4eab84af5, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.26 0.09 0.08
query4 1.62 0.11 0.11
query5 0.28 0.25 0.25
query6 1.18 0.63 0.66
query7 0.03 0.03 0.03
query8 0.05 0.05 0.04
query9 0.59 0.52 0.51
query10 0.58 0.57 0.58
query11 0.16 0.12 0.12
query12 0.15 0.12 0.12
query13 0.63 0.61 0.60
query14 0.99 1.00 1.01
query15 0.84 0.83 0.83
query16 0.40 0.40 0.38
query17 1.06 1.01 1.01
query18 0.21 0.20 0.20
query19 1.87 1.82 1.83
query20 0.02 0.01 0.02
query21 15.47 0.19 0.14
query22 5.12 0.07 0.05
query23 15.67 0.27 0.11
query24 2.73 1.32 0.28
query25 0.07 0.06 0.06
query26 0.14 0.14 0.13
query27 0.06 0.06 0.06
query28 4.52 1.13 0.93
query29 12.59 3.93 3.31
query30 0.27 0.13 0.12
query31 2.82 0.60 0.37
query32 3.23 0.55 0.47
query33 3.05 3.02 3.07
query34 15.93 5.20 4.57
query35 4.59 4.58 4.57
query36 0.66 0.50 0.49
query37 0.09 0.06 0.07
query38 0.07 0.04 0.04
query39 0.03 0.03 0.02
query40 0.17 0.15 0.13
query41 0.08 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.51 s
Total hot run time: 27.43 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cast) simplify CastExpr's code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57775:
URL: https://github.com/apache/doris/pull/57775#issuecomment-3501167938
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org