[airflow] branch main updated: removed recommendation for using 'token' as login in databricks connection when using auth via PAT (#25435)

[po...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 6ef15840d5 removed recommendation for using 'token' as login in databricks connection when using auth via PAT (#25435)
6ef15840d5 is described below

commit 6ef15840d5e3800381b42778784801b95bdb07c2
Author: ttomasz <31...@users.noreply.github.com>
AuthorDate: Tue Aug 2 21:33:34 2022 +0200

    removed recommendation for using 'token' as login in databricks connection when using auth via PAT (#25435)
    
    * removed recommendation for using 'token' as login in databricks connection when using auth via PAT
    
    in the code the condition that decides whether to use PAT token is checking whether login is empty not whether it is 'token' https://github.com/apache/airflow/blob/main/airflow/providers/databricks/hooks/databricks_base.py#L421
    
    * added more detail to description of login options
---
 docs/apache-airflow-providers-databricks/connections/databricks.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/apache-airflow-providers-databricks/connections/databricks.rst b/docs/apache-airflow-providers-databricks/connections/databricks.rst
index cb62ada113..d44f790a87 100644
--- a/docs/apache-airflow-providers-databricks/connections/databricks.rst
+++ b/docs/apache-airflow-providers-databricks/connections/databricks.rst
@@ -55,11 +55,12 @@ Host (required)
 Login (optional)
     * If authentication with *Databricks login credentials* is used then specify the ``username`` used to login to Databricks.
     * If *authentication with Azure Service Principal* is used then specify the ID of the Azure Service Principal
+    * If authentication with *PAT* is used then either leave this field empty or use 'token' as login (both work, the only difference is that if login is empty then token will be sent in request header as Bearer token, if login is 'token' then it will be sent using Basic Auth which is allowed by Databricks API, this may be useful if you plan to reuse this connection with e.g. SimpleHttpOperator)
 
 Password (optional)
     * If authentication with *Databricks login credentials*  is used then specify the ``password`` used to login to Databricks.
     * If authentication with *Azure Service Principal* is used then specify the secret of the Azure Service Principal
-    * if authentication with *PAT* is used, then specify PAT and use ``token`` as the login (recommended)
+    * If authentication with *PAT* is used, then specify PAT (recommended)
 
 Extra (optional)
     Specify the extra parameter (as json dictionary) that can be used in the Databricks connection.