You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/06 13:26:19 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #7772: support subscription position and expose the producer settings
315157973 opened a new pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772
Fixes #7622
### Motivation
1 We cannot specify the consume position of the function
2 Pulsar Functions doesn't expose the producer settings publicly
### Modifications
1 The `subscription position` setting already exists in the code, but this parameter is not exposed to the outside, so I exposed this setting in `FunctionConfig`
2 Added the general parameter `outputSpecs`, all producer settings can be passed in through it.
3 Expose the producer settings publicly to pulsar source as well
### Verifying this change
unit tests
org.apache.pulsar.io.PulsarFunctionE2ETest#testOutputSpecs
org.apache.pulsar.io.PulsarFunctionE2ETest#testReadPositionEarliest
org.apache.pulsar.io.PulsarFunctionE2ETest#testReadPositionLatest
org.apache.pulsar.io.PulsarFunctionE2ETest#testSinkProducerSetting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690896533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-691446138
> @315157973 Can you merge the master code and fix conflict?
@wolfstudy Please help review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-691420795
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690881332
@315157973 Can you merge the master code and fix conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-676256426
Could someone help CR？
@sijie @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-677453835
@nlu90 Please help review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690896533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 closed pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 closed pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690881332
@315157973 Can you merge the master code and fix conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690896533
OK, I will solve it as soon as possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690881332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-690881332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #7772: support subscription position and expose the producer settings
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #7772:
URL: https://github.com/apache/pulsar/pull/7772#issuecomment-691370288
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org