You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by benbenw <gi...@git.apache.org> on 2016/01/13 00:44:21 UTC
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/70
Bug 58845 : http request view doesn't display all the parameters
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter requestviewhttp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/70.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #70
----
commit 393be7bf79f9e45d42d881ffd1337ee83745de51
Author: benoit <b....@ubik-ingenierie.com>
Date: 2016-01-12T23:40:51Z
http request view doesn't display all the parameters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by benbenw <gi...@git.apache.org>.
Github user benbenw commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171412112
I can not add a test for the previous behavior as the method signature is wrong : the query is parsed into a Map<String, String> where you can only have 1 value per parameter name...
If you can have a look at bug 58851, I will add a test with my PR that test that all the parameters are displayed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171238944
Can you provide a test case to show the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171403740
Yes, to show which kind of params are missing in the display
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171425357
Not a junit test, a jmeter test (.jmx)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by benbenw <gi...@git.apache.org>.
Github user benbenw commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171427042
ok
attached the test I've used for my PR to bugzilla
run the test and have a look at the result in the request http view
parameters defined in the http sampler are missing
the sampler is fine it's just the display
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 58845 : http request view doesn't display...
Posted by benbenw <gi...@git.apache.org>.
Github user benbenw commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171288167
you mean a test for the new behavior ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---