[GitHub] [phoenix] abhishek-chouhan commented on a change in pull request #698: PHOENIX-5704 Covered column updates are not generated for previously …

[GitBox <gi...@apache.org>]

abhishek-chouhan commented on a change in pull request #698: PHOENIX-5704 Covered column updates are not generated for previously …
URL: https://github.com/apache/phoenix/pull/698#discussion_r373748897
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
 ##########
 @@ -785,9 +785,51 @@ private void testUpsertingDeletedRowShouldGiveProperDataWithIndexes(boolean mult
           assertEquals(0.5F, rs.getFloat(1), 0.0);
           assertEquals("foo", rs.getString(3));
       }
-  }
+    }
+
+    @Test
+    public void testUpsertingDeletedRowWithNullCoveredColumn() throws Exception {
+        testUpsertingDeletedRowWithNullCoveredColumn(false);
+    }
 
-  /**
+    @Test
+    public void testUpsertingDeletedRowWithNullCoveredColumnMultiCfs() throws Exception {
+        testUpsertingDeletedRowWithNullCoveredColumn(true);
+    }
+
+    public void testUpsertingDeletedRowWithNullCoveredColumn(boolean multiCf) throws Exception {
+        String tableName = "TBL_" + generateUniqueName();
+        String indexName = "IDX_" + generateUniqueName();
+        String columnFamily1 = "cf1";
+        String columnFamily2 = "cf2";
+        String fullTableName = SchemaUtil.getTableName(TestUtil.DEFAULT_SCHEMA_NAME, tableName);
+        String fullIndexName = SchemaUtil.getTableName(TestUtil.DEFAULT_SCHEMA_NAME, indexName);
+        try (Connection conn = getConnection()) {
+            conn.createStatement()
+                    .execute("create table " + fullTableName + " (id integer primary key, "
+                            + (multiCf ? columnFamily1 : "") + "f varchar, "
 
 Review comment:
   Updated the test to fix this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services