You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 00:07:16 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #9039: ARROW-10416: [R] Support Tables in Flight
nealrichardson opened a new pull request #9039:
URL: https://github.com/apache/arrow/pull/9039
In addition to the feature described in the title, this PR
* renames `push_data()` to `flight_put()` and adds an `overwrite` argument to optionally check for the existence of a flight with the the same name
* adds `list_flights()` and `flight_path_exists()` to see available resources
* adds tests for the flight bindings, run if the demo flight server is found to be running (managing that process and/or running this in CI is deferred)
* makes the R-Python conversion preserve schema metadata when converting Tables, with some hacking around bytestrings in reticulate. Will look into a more direct path for moving the schema, which isn't currently exposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #9039: ARROW-10416: [R] Support Tables in Flight
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9039:
URL: https://github.com/apache/arrow/pull/9039#discussion_r549925235
##########
File path: r/tests/testthat/test-python-flight.R
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Assumes:
+# * We've already done arrow::install_pyarrow()
+# * R -e 'arrow::load_flight_server("demo_flight_server")$DemoFlightServer(port = 8089)$serve()'
+# TODO: set up CI job to test this, or some way of running a background process
Review comment:
You probably already know about it, but I believe processx should be able to kick this off
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9039: ARROW-10416: [R] Support Tables in Flight
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9039:
URL: https://github.com/apache/arrow/pull/9039#issuecomment-751915453
https://issues.apache.org/jira/browse/ARROW-10416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9039: ARROW-10416: [R] Support Tables in Flight
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9039:
URL: https://github.com/apache/arrow/pull/9039#issuecomment-752235632
Passing build on my fork: https://github.com/nealrichardson/arrow/actions/runs/451112536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #9039: ARROW-10416: [R] Support Tables in Flight
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9039:
URL: https://github.com/apache/arrow/pull/9039#discussion_r550251893
##########
File path: r/tests/testthat/test-python-flight.R
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Assumes:
+# * We've already done arrow::install_pyarrow()
+# * R -e 'arrow::load_flight_server("demo_flight_server")$DemoFlightServer(port = 8089)$serve()'
+# TODO: set up CI job to test this, or some way of running a background process
Review comment:
Yeah I made ARROW-11071 for that, will take that up separately because there's a bit more build script refactoring involved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9039: ARROW-10416: [R] Support Tables in Flight
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9039:
URL: https://github.com/apache/arrow/pull/9039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org