You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/09 09:17:23 UTC
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #10040: [Bug] [Vectorized] code dump on aggregate node over union node
BiteTheDDDDt opened a new pull request, #10040:
URL: https://github.com/apache/incubator-doris/pull/10040
# Proposed changes
Issue Number: close #10038
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040#discussion_r893411150
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -283,14 +283,12 @@ private boolean isChildPassthrough(
if (childSlotRef == null) {
return false;
}
- if (VectorizedUtil.isVectorized()) {
- if (childSlotRef.getDesc().getSlotOffset() != setOpSlotRef.getDesc().getSlotOffset()) {
- return false;
- }
- } else {
- if (!childSlotRef.getDesc().layoutEquals(setOpSlotRef.getDesc())) {
- return false;
- }
+ if (VectorizedUtil.isVectorized()
+ && childSlotRef.getDesc().getSlotOffset() != setOpSlotRef.getDesc().getSlotOffset()) {
Review Comment:
maybe it it better to only check type and nullable when use vectorized engine, then we have more chance to do passthrough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040#issuecomment-1151014118
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040#discussion_r893589333
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -283,14 +283,12 @@ private boolean isChildPassthrough(
if (childSlotRef == null) {
return false;
}
- if (VectorizedUtil.isVectorized()) {
- if (childSlotRef.getDesc().getSlotOffset() != setOpSlotRef.getDesc().getSlotOffset()) {
- return false;
- }
- } else {
- if (!childSlotRef.getDesc().layoutEquals(setOpSlotRef.getDesc())) {
- return false;
- }
+ if (VectorizedUtil.isVectorized()
+ && childSlotRef.getDesc().getSlotOffset() != setOpSlotRef.getDesc().getSlotOffset()) {
Review Comment:
> maybe it it better to only check type and nullable when use vectorized engine, then we have more chance to do passthrough
Hi, I made an update, please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040#issuecomment-1151156420
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040#issuecomment-1151209330
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org