You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/09 16:34:06 UTC

[GitHub] [cloudstack-primate] ravening opened a new pull request #681: Enable tags for lb rules

ravening opened a new pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681


   Fixes #679 
   
   Use updateLoadBalancerRule instead editLoadBalancerRule
   
   There is no editLoadBalancerRule api
   
   After the fix, im able to see and add tags to lb rules
   
   ![Screenshot 2020-09-09 at 18 30 46](https://user-images.githubusercontent.com/10645273/92626936-f1aa3200-f2ca-11ea-8c15-a0ead66e844b.png)
   
   ![Screenshot 2020-09-09 at 18 30 55](https://user-images.githubusercontent.com/10645273/92626952-f5d64f80-f2ca-11ea-8e6b-640135cfcaa6.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-689871812


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-689871307


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694837132


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694837353


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-692616838


   ping @ravening - can you address David's comment? Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-689874624


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/681 (JID-3452)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] ravening commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-692617379


   > ping @ravening - can you address David's comment? Thanks
   
   Didn't get time so far.. will work on it either today or tomorrow


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-689995262


   Thanks @ravening Could you also fix allowing delete tags in the same vue ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-693297032


   Thanks @ravening 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] ravening commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694790379


   @davidjumani @rhtyd made the change. Please review
   
   ![Screenshot 2020-09-18 at 12 30 06](https://user-images.githubusercontent.com/10645273/93587772-aff44800-f9aa-11ea-893b-9d9dac1543bb.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #681: Enable tags for lb rules

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #681:
URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694841240


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/681 (JID-3488)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org