You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/24 17:18:00 UTC
[jira] [Commented] (WICKET-6657) change replaceAll() to replace()
when a regex is not used
[ https://issues.apache.org/jira/browse/WICKET-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825356#comment-16825356 ]
ASF subversion and git services commented on WICKET-6657:
---------------------------------------------------------
Commit 5c3478e20e75a5dd2fa64ad290321f66f6397bd2 in wicket's branch refs/heads/master from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=5c3478e ]
WICKET-6657 change replaceAll() to replace() when a regex is not used
closes #354
> change replaceAll() to replace() when a regex is not used
> ---------------------------------------------------------
>
> Key: WICKET-6657
> URL: https://issues.apache.org/jira/browse/WICKET-6657
> Project: Wicket
> Issue Type: Improvement
> Reporter: bd2019us
> Priority: Trivial
> Labels: pull-request-available
> Attachments: WICKET-6657.patch
>
>
> When a regex is not used, replace() is more optimal than replaceAll() because replaceAll() has extra performance overhead from attempting to compile the unused regex
> Affected file:
> * wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)