You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.co.il> on 2008/04/21 17:56:31 UTC

svn commit: r30723, r30730

Good morning Stefan,

A few comments on the dont-* branch.

> --- subversion/libsvn_subr/config_file.c	(revision 30722)
> +++ subversion/libsvn_subr/config_file.c	(revision 30723)
> @@ -793,6 +793,17 @@ svn_config_ensure(const char *config_dir
> +        "###                              on disk unencrypted."              NL
> +        "###"                                                                NL
> +        "### store-plaintext-passwords may be either 'yes', 'no', or 'prompt'."                                                                              NL

This line is 160 characters long.

> @@ -822,12 +833,13 @@ svn_config_ensure(const char *config_dir
>          "# http-proxy-port = 9000"                                           NL
> -        "# No username and password, so use the defaults below."             NL
> +        "# No username and password for the proxy, so use the defaults below."                                                                               NL

So is this one.

> --- subversion/libsvn_subr/prompt.c	(revision 30729)
> +++ subversion/libsvn_subr/prompt.c	(revision 30731)
> @@ -385,6 +385,7 @@ svn_cmdline_auth_plaintext_prompt(svn_boolean_t *m
>    const char *answer = NULL;
>    svn_boolean_t answered = FALSE;
>    const char *prompt_string = _("Store password unencrypted (yes/no)? ");
> +  svn_cmdline_prompt_baton2_t *pb = baton;

The function's docstring should be updated to reflect that @a baton is
now used.

Daniel


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org