[jira] [Commented] (DRILL-5094) Assure Comparator to be transitive

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713971#comment-15713971 ] 

ASF GitHub Bot commented on DRILL-5094:
---------------------------------------

GitHub user chunhui-shi opened a pull request:

    https://github.com/apache/drill/pull/675

    DRILL-5094: Comparator should guarantee transitive attribute.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chunhui-shi/drill DRILL-5094

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #675
    
----
commit 90e874a3e38cdfdac9067d55e6829c048bcb459b
Author: chunhui-shi <cs...@maprtech.com>
Date:   2016-12-02T01:55:12Z

    DRILL-5094: Comparator should guarantee transitive attribute.

----


> Assure Comparator to be transitive
> ----------------------------------
>
>                 Key: DRILL-5094
>                 URL: https://issues.apache.org/jira/browse/DRILL-5094
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Chunhui Shi
>            Assignee: Chunhui Shi
>            Priority: Critical
>
> In AssignmentCreator.java, one Comparator could break transitive attribute required for a Comparator implementation and the result is not correct.
> E.g. for:
> long IntPlusOne = 0x80000000L;
> [0]=2 * IntPlusOne + 5, [1] = 2* IntPlusOne + 8, [2] = 4 * IntPlusOne + 4,
> the compare results will be like:
> compare([0],[1]) = -3,
> compare([1],[2]) = 4,
> compare([0],[2]) = 1 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)