You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Francis Chuang (JIRA)" <ji...@apache.org> on 2018/06/26 00:57:01 UTC

[jira] [Updated] (CALCITE-839) Remove Jackson annotations from POJO classes in Meta

     [ https://issues.apache.org/jira/browse/CALCITE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francis Chuang updated CALCITE-839:
-----------------------------------
    Fix Version/s:     (was: avatica-1.12.0)
                   avatica-1.13.0

> Remove Jackson annotations from POJO classes in Meta
> ----------------------------------------------------
>
>                 Key: CALCITE-839
>                 URL: https://issues.apache.org/jira/browse/CALCITE-839
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Julian Hyde
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: avatica-1.13.0
>
>
> The Meta interface contains several POJO classes that represent RPC requests or responses. Currently a few of those classes have Jackson annotations such as @JsonCreator, @JsonProperty to help Jackson serialize the POJO to JSON and de-serialize from JSON to the object.
> As [~ndimiduk] pointed out in http://mail-archives.apache.org/mod_mbox/calcite-dev/201503.mbox/%3CCANZa=GvKGD+BKJ4+eJMuO6iVhS+OkGSkG1VwDAZCy-ZijyyyPw@mail.gmail.com%3E these annotations are a "code smell" and should be removed. It makes it look as if Jackson is the only possible transport, which is not the case. We can continue to use Jackson as a transport, just specify the mappings elsewhere, not as annotations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)