You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 08:16:55 UTC

[GitHub] [arrow] AlenkaF commented on a diff in pull request #14631: ARROW-18173: [Python] Drop older versions of Pandas (<1.0)

AlenkaF commented on code in PR #14631:
URL: https://github.com/apache/arrow/pull/14631#discussion_r1022467124


##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1794,13 +1794,9 @@ def test_strptime():
 @pytest.mark.skipif(sys.platform == 'win32',
                     reason="Timezone database is not available on Windows yet")
 def test_strftime():
-    from pyarrow.vendored.version import Version
 
     def _fix_timestamp(s):
-        if Version(pd.__version__) < Version("1.0.0"):
-            return s.to_series().replace("NaT", pd.NaT)
-        else:
-            return s
+        return s

Review Comment:
   Oh, haven't even realised what I left here 🤦‍♀️  Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org